[PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1962d LANDED

Landed in mainline as 2235dea17d56 on 2021-04-14.

2 messages, 2 authors, 2021-04-19 · open the first message on its own page

[PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static

From: Bixuan Cui <hidden>
Date: 2021-04-09 09:02:47

The sparse tool complains as follows:

arch/powerpc/platforms/pseries/pmem.c:142:27: warning:
 symbol 'drc_pmem_match' was not declared. Should it be static?

This symbol is not used outside of pmem.c, so this
commit marks it static.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Bixuan Cui <redacted>
---
 arch/powerpc/platforms/pseries/pmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c
index e1dc5d3254df..439ac72c2470 100644
--- a/arch/powerpc/platforms/pseries/pmem.c
+++ b/arch/powerpc/platforms/pseries/pmem.c
@@ -139,7 +139,7 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)
 	return rc;
 }
 
-const struct of_device_id drc_pmem_match[] = {
+static const struct of_device_id drc_pmem_match[] = {
 	{ .type = "ibm,persistent-memory", },
 	{}
 };

Re: [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static

From: Michael Ellerman <hidden>
Date: 2021-04-19 04:04:58

On Fri, 9 Apr 2021 17:01:14 +0800, Bixuan Cui wrote:
The sparse tool complains as follows:

arch/powerpc/platforms/pseries/pmem.c:142:27: warning:
 symbol 'drc_pmem_match' was not declared. Should it be static?

This symbol is not used outside of pmem.c, so this
commit marks it static.
Applied to powerpc/next.

[1/1] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static
      https://git.kernel.org/powerpc/c/2235dea17d56238642121a8085b71d68598534bb

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help