# Re: \[PATCH 08/18\] iommu/fsl\_pamu: merge pamu\_set\_liodn and map\_liodn

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-04-01 09:34:56 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/04/8286234
- Thread: https://ratatoskr.run/linuxppc-dev/2021/03/8286060/t.md

```text
On Tue, Mar 30, 2021 at 01:46:51PM +0100, Will Deacon wrote:
> > +	ret = pamu_config_ppaace(liodn, geom->aperture_start,
> > +				 geom->aperture_end - 1, ~(u32)0,
> > +				 0, dma_domain->snoop_id, dma_domain->stash_id,
> > +				 PAACE_AP_PERMS_QUERY | PAACE_AP_PERMS_UPDATE);
> 
> There's more '+1' / '-1' confusion here with aperture_end which I'm not
> managing to follow. What am I missing?

You did not missing anything, I messed this up.   Fixed.
```
