# Re: \[PATCH 06/18\] iommu/fsl\_pamu: remove -\>domain\_window\_enable

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2021-04-01 09:32:47 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/04/8286233
- Thread: https://ratatoskr.run/linuxppc-dev/2021/03/8286060/t.md

```text
On Tue, Mar 30, 2021 at 01:40:09PM +0100, Will Deacon wrote:
> > +	ret = pamu_config_ppaace(liodn, geom->aperture_start,
> > +				 geom->aperture_end - 1, ~(u32)0,
> 
> You're passing 'geom->aperture_end - 1' as the size here, but the old code
> seemed to _add_ 1:
> 

> > -	win_size = (domain->geometry.aperture_end + 1) >> ilog2(1);
> 
> here ^^ when calculating the exclusive upper bound. In other words, I think
> '1ULL << 36' used to get passed to pamu_config_ppaace(). Is that an
> intentional change?

No, I've fixed it up.
```
