# Re: \[PATCH net-next v4 2/2\] of: net: fix of\_get\_mac\_addr\_nvmem() for non-platform devices

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2021-04-13 00:57:24 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/04/6336807
- Thread: https://ratatoskr.run/linuxppc-dev/2021/04/6336476/t.md

```text
On Mon, Apr 12, 2021 at 07:47:18PM +0200, Michael Walle wrote:
> of_get_mac_address() already supports fetching the MAC address by an
> nvmem provider. But until now, it was just working for platform devices.
> Esp. it was not working for DSA ports and PCI devices. It gets more
> common that PCI devices have a device tree binding since SoCs contain
> integrated root complexes.
> 
> Use the nvmem of_* binding to fetch the nvmem cells by a struct
> device_node. We still have to try to read the cell by device first
> because there might be a nvmem_cell_lookup associated with that device.
> 
> Signed-off-by: Michael Walle <redacted>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
```
