[PATCH -next] powerpc/pmac: Make some symbols static

Subsystems: linux for power macintosh, linux for powerpc (32-bit and 64-bit), the rest

STALE1613d

2 messages, 2 authors, 2022-03-02 · open the first message on its own page

[PATCH -next] powerpc/pmac: Make some symbols static

From: Zucheng Zheng <hidden>
Date: 2021-04-09 09:38:15

ppc_override_l2cr/ppc_override_l2cr_value/has_l2cache symbol is not used
outside of setup.c, so commit marks it static.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Zucheng Zheng <redacted>
---
 arch/powerpc/platforms/powermac/setup.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
index 86aee3f2483f..db5107c80485 100644
--- a/arch/powerpc/platforms/powermac/setup.c
+++ b/arch/powerpc/platforms/powermac/setup.c
@@ -71,9 +71,9 @@
 
 #undef SHOW_GATWICK_IRQS
 
-int ppc_override_l2cr = 0;
-int ppc_override_l2cr_value;
-int has_l2cache = 0;
+static int ppc_override_l2cr;
+static int ppc_override_l2cr_value;
+static int has_l2cache;
 
 int pmac_newworld;
 
-- 
2.17.1

Re: [PATCH -next] powerpc/pmac: Make some symbols static

From: Christophe Leroy <hidden>
Date: 2022-03-02 13:23:38


Le 09/04/2021 à 11:38, Zucheng Zheng a écrit :
quoted hunk
ppc_override_l2cr/ppc_override_l2cr_value/has_l2cache symbol is not used
outside of setup.c, so commit marks it static.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Zucheng Zheng <redacted>
---
  arch/powerpc/platforms/powermac/setup.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
index 86aee3f2483f..db5107c80485 100644
--- a/arch/powerpc/platforms/powermac/setup.c
+++ b/arch/powerpc/platforms/powermac/setup.c
@@ -71,9 +71,9 @@
  
  #undef SHOW_GATWICK_IRQS
  
-int ppc_override_l2cr = 0;
-int ppc_override_l2cr_value;
-int has_l2cache = 0;
+static int ppc_override_l2cr;
+static int ppc_override_l2cr_value;
+static int has_l2cache;
  
  int pmac_newworld;
  
With ppc64_defconfig,

   CC      arch/powerpc/platforms/powermac/setup.o
arch/powerpc/platforms/powermac/setup.c:75:12: error: 
'ppc_override_l2cr_value' defined but not used [-Werror=unused-variable]
    75 | static int ppc_override_l2cr_value;
       |            ^~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/platforms/powermac/setup.c:74:12: error: 
'ppc_override_l2cr' defined but not used [-Werror=unused-variable]
    74 | static int ppc_override_l2cr;
       |            ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [scripts/Makefile.build:288: 
arch/powerpc/platforms/powermac/setup.o] Error 1


You have to move it inside the #ifdef CONFIG_PPC32 block that uses it.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help