[PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1933d LANDED

Landed in mainline as f6f1f48e8b3b on 2021-04-14.

2 messages, 2 authors, 2021-04-19 · open the first message on its own page

[PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static

From: Li Huafei <hidden>
Date: 2021-04-08 03:58:18

The sparse tool complains as follows:

arch/powerpc/kernel/mce.c:43:1: warning:
 symbol 'mce_ue_event_work' was not declared. Should it be static?

This symbol is not used outside of mce.c, so this commit marks it
static.

Signed-off-by: Li Huafei <redacted>
---
 arch/powerpc/kernel/mce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
index 11f0cae086ed..6aa6b1cda1ed 100644
--- a/arch/powerpc/kernel/mce.c
+++ b/arch/powerpc/kernel/mce.c
@@ -40,7 +40,7 @@ static struct irq_work mce_ue_event_irq_work = {
 	.func = machine_check_ue_irq_work,
 };
 
-DECLARE_WORK(mce_ue_event_work, machine_process_ue_event);
+static DECLARE_WORK(mce_ue_event_work, machine_process_ue_event);
 
 static BLOCKING_NOTIFIER_HEAD(mce_notifier_list);
 
-- 
2.17.1

Re: [PATCH -next] powerpc/mce: Make symbol 'mce_ue_event_work' static

From: Michael Ellerman <hidden>
Date: 2021-04-19 04:05:14

On Thu, 8 Apr 2021 11:58:02 +0800, Li Huafei wrote:
The sparse tool complains as follows:

arch/powerpc/kernel/mce.c:43:1: warning:
 symbol 'mce_ue_event_work' was not declared. Should it be static?

This symbol is not used outside of mce.c, so this commit marks it
static.
Applied to powerpc/next.

[1/1] powerpc/mce: Make symbol 'mce_ue_event_work' static
      https://git.kernel.org/powerpc/c/f6f1f48e8b3b242dfa684d6e1b930d239d87533a

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help