[PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static

Subsystems: linux for power macintosh, the rest

STALE1934d LANDED

Landed in mainline as 13ddd0e3acf9 on 2021-04-14.

2 messages, 2 authors, 2021-04-19 · open the first message on its own page

[PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static

From: Yu Kuai <hidden>
Date: 2021-04-07 12:49:30

The sparse tool complains as follows:

drivers/macintosh/windfarm_pm121.c:436:24: warning:
 symbol 'pm121_sys_state' was not declared. Should it be static?

This symbol is not used outside of windfarm_pm121.c, so this
commit marks it static.

Reported-by: Hulk Robot <redacted>
Signed-off-by: Yu Kuai <redacted>
---
 drivers/macintosh/windfarm_pm121.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c
index ab467b9c31be..ba1ec6fc11d2 100644
--- a/drivers/macintosh/windfarm_pm121.c
+++ b/drivers/macintosh/windfarm_pm121.c
@@ -433,7 +433,7 @@ struct pm121_sys_state {
 	struct wf_pid_state	pid;
 };
 
-struct pm121_sys_state *pm121_sys_state[N_LOOPS] = {};
+static struct pm121_sys_state *pm121_sys_state[N_LOOPS] = {};
 
 /*
  * ****** CPU Fans Control Loop ******
-- 
2.25.4

Re: [PATCH] macintosh/windfarm: Make symbol 'pm121_sys_state' static

From: Michael Ellerman <hidden>
Date: 2021-04-19 04:07:03

On Wed, 7 Apr 2021 20:57:12 +0800, Yu Kuai wrote:
The sparse tool complains as follows:

drivers/macintosh/windfarm_pm121.c:436:24: warning:
 symbol 'pm121_sys_state' was not declared. Should it be static?

This symbol is not used outside of windfarm_pm121.c, so this
commit marks it static.
Applied to powerpc/next.

[1/1] macintosh/windfarm: Make symbol 'pm121_sys_state' static
      https://git.kernel.org/powerpc/c/13ddd0e3acf988a98b46800178ae691640b0cd00

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help