# Re: \[PATCH 07/18\] iommu/fsl\_pamu: replace DOMAIN\_ATTR\_FSL\_PAMU\_STASH with a direct call

- From: Will Deacon \<will@kernel.org\>
- Date: 2021-03-30 12:45:25 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/03/8286186
- Thread: https://ratatoskr.run/linuxppc-dev/2021/03/8286060/t.md

```text
On Tue, Mar 16, 2021 at 04:38:13PM +0100, Christoph Hellwig wrote:
> Add a fsl_pamu_configure_l1_stash API that qman_portal can call directly
> instead of indirecting through the iommu attr API.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Li Yang <redacted>
> ---
>  arch/powerpc/include/asm/fsl_pamu_stash.h | 12 +++---------
>  drivers/iommu/fsl_pamu_domain.c           | 16 +++-------------
>  drivers/iommu/fsl_pamu_domain.h           |  2 --
>  drivers/soc/fsl/qbman/qman_portal.c       | 18 +++---------------
>  include/linux/iommu.h                     |  1 -
>  5 files changed, 9 insertions(+), 40 deletions(-)

Heh, this thing is so over-engineered.

Acked-by: Will Deacon <will@kernel.org>

Will
```
