[PATCH] powerpc: powernv: Remove unneeded variable: "rc"

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1974d LANDED

Landed in mainline as 69931cc387cc on 2021-03-29.

3 messages, 3 authors, 2021-03-31 · open the first message on its own page

[PATCH] powerpc: powernv: Remove unneeded variable: "rc"

From: <hidden>
Date: 2021-03-26 11:56:47

From: dingsenjie <redacted>

Remove unneeded variable: "rc".

Signed-off-by: dingsenjie <redacted>
---
 arch/powerpc/platforms/powernv/opal-prd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal-prd.c b/arch/powerpc/platforms/powernv/opal-prd.c
index deddaeb..a191f4c 100644
--- a/arch/powerpc/platforms/powernv/opal-prd.c
+++ b/arch/powerpc/platforms/powernv/opal-prd.c
@@ -105,7 +105,6 @@ static int opal_prd_mmap(struct file *file, struct vm_area_struct *vma)
 {
 	size_t addr, size;
 	pgprot_t page_prot;
-	int rc;
 
 	pr_devel("opal_prd_mmap(0x%016lx, 0x%016lx, 0x%lx, 0x%lx)\n",
 			vma->vm_start, vma->vm_end, vma->vm_pgoff,
@@ -121,10 +120,8 @@ static int opal_prd_mmap(struct file *file, struct vm_area_struct *vma)
 	page_prot = phys_mem_access_prot(file, vma->vm_pgoff,
 					 size, vma->vm_page_prot);
 
-	rc = remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff, size,
+	return remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff, size,
 				page_prot);
-
-	return rc;
 }
 
 static bool opal_msg_queue_empty(void)
-- 
1.9.1

Re: [PATCH] powerpc: powernv: Remove unneeded variable: "rc"

From: Andrew Donnellan <hidden>
Date: 2021-03-26 15:00:41

On 26/3/21 10:53 pm, dingsenjie@163.com wrote:
From: dingsenjie <redacted>

Remove unneeded variable: "rc".

Signed-off-by: dingsenjie <redacted>
This looks obviously correct and doesn't raise any checkpatch warnings.

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
ajd@linux.ibm.com             IBM Australia Limited

Re: [PATCH] powerpc: powernv: Remove unneeded variable: "rc"

From: Michael Ellerman <hidden>
Date: 2021-03-31 01:11:02

On Fri, 26 Mar 2021 19:53:56 +0800, dingsenjie@163.com wrote:
Remove unneeded variable: "rc".
Applied to powerpc/next.

[1/1] powerpc: powernv: Remove unneeded variable: "rc"
      https://git.kernel.org/powerpc/c/69931cc387cca289e0415c79ce5389119670066d

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help