[PATCH] powerpc/iommu/debug: fix ifnullfree.cocci warnings

STALE1971d LANDED

Landed in mainline as bbbe563f8490 on 2021-03-29.

2 messages, 2 authors, 2021-03-31 · open the first message on its own page

[PATCH] powerpc/iommu/debug: fix ifnullfree.cocci warnings

From: kernel test robot <hidden>
Date: 2021-03-18 23:45:59

From: kernel test robot <redacted>

arch/powerpc/kernel/iommu.c:76:2-16: WARNING: NULL check before some freeing functions is not needed.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: 691602aab9c3 ("powerpc/iommu/debug: Add debugfs entries for IOMMU tables")
CC: Alexey Kardashevskiy <redacted>
Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   81aa0968b7ea6dbabcdcda37dc8434dca6e1565b
commit: 691602aab9c3cce31d3ff9529c09b7922a5f6224 powerpc/iommu/debug: Add debugfs entries for IOMMU tables

 iommu.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--- a/arch/powerpc/kernel/iommu.c
+++ b/arch/powerpc/kernel/iommu.c
@@ -72,8 +72,7 @@ static void iommu_debugfs_del(struct iom
 
 	sprintf(name, "%08lx", tbl->it_index);
 	liobn_entry = debugfs_lookup(name, iommu_debugfs_dir);
-	if (liobn_entry)
-		debugfs_remove(liobn_entry);
+	debugfs_remove(liobn_entry);
 }
 #else
 static void iommu_debugfs_add(struct iommu_table *tbl){}

Re: [PATCH] powerpc/iommu/debug: fix ifnullfree.cocci warnings

From: Michael Ellerman <hidden>
Date: 2021-03-31 01:11:31

On Fri, 19 Mar 2021 07:44:41 +0800, kernel test robot wrote:
arch/powerpc/kernel/iommu.c:76:2-16: WARNING: NULL check before some freeing functions is not needed.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

[...]
Applied to powerpc/next.

[1/1] powerpc/iommu/debug: fix ifnullfree.cocci warnings
      https://git.kernel.org/powerpc/c/bbbe563f8490958861777d98871e16960163ea1b

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help