[PATCH] powerpc/asm-offsets: GPR14 is not needed either

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1979d LANDED

Landed in mainline as 6eeca7a11379 on 2021-03-29.

3 messages, 3 authors, 2021-03-31 · open the first message on its own page

[PATCH] powerpc/asm-offsets: GPR14 is not needed either

From: Christophe Leroy <hidden>
Date: 2021-03-15 11:02:45

Commit aac6a91fea93 ("powerpc/asm: Remove unused symbols in
asm-offsets.c") removed GPR15 to GPR31 but kept GPR14,
probably because it pops up in a couple of comments when doing
a grep.

However, it was never used either, so remove it as well.

Fixes: aac6a91fea93 ("powerpc/asm: Remove unused symbols in asm-offsets.c")
Cc: Rashmica Gupta <redacted>
Signed-off-by: Christophe Leroy <redacted>
---
 arch/powerpc/kernel/asm-offsets.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c
index f3a662201a9f..4d230c5c7099 100644
--- a/arch/powerpc/kernel/asm-offsets.c
+++ b/arch/powerpc/kernel/asm-offsets.c
@@ -323,9 +323,6 @@ int main(void)
 	STACK_PT_REGS_OFFSET(GPR11, gpr[11]);
 	STACK_PT_REGS_OFFSET(GPR12, gpr[12]);
 	STACK_PT_REGS_OFFSET(GPR13, gpr[13]);
-#ifndef CONFIG_PPC64
-	STACK_PT_REGS_OFFSET(GPR14, gpr[14]);
-#endif /* CONFIG_PPC64 */
 	/*
 	 * Note: these symbols include _ because they overlap with special
 	 * register names
-- 
2.25.0

Re: [PATCH] powerpc/asm-offsets: GPR14 is not needed either

From: Rashmica Gupta <hidden>
Date: 2021-03-25 03:35:32

On Mon, 2021-03-15 at 11:01 +0000, Christophe Leroy wrote:
Commit aac6a91fea93 ("powerpc/asm: Remove unused symbols in
asm-offsets.c") removed GPR15 to GPR31 but kept GPR14,
probably because it pops up in a couple of comments when doing
a grep.

However, it was never used either, so remove it as well.
Looks good to me.

Reviewed-by: Rashmica Gupta <redacted>
quoted hunk
Fixes: aac6a91fea93 ("powerpc/asm: Remove unused symbols in asm-
offsets.c")
Cc: Rashmica Gupta <redacted>
Signed-off-by: Christophe Leroy <redacted>
---
 arch/powerpc/kernel/asm-offsets.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/arch/powerpc/kernel/asm-offsets.c
b/arch/powerpc/kernel/asm-offsets.c
index f3a662201a9f..4d230c5c7099 100644
--- a/arch/powerpc/kernel/asm-offsets.c
+++ b/arch/powerpc/kernel/asm-offsets.c
@@ -323,9 +323,6 @@ int main(void)
 	STACK_PT_REGS_OFFSET(GPR11, gpr[11]);
 	STACK_PT_REGS_OFFSET(GPR12, gpr[12]);
 	STACK_PT_REGS_OFFSET(GPR13, gpr[13]);
-#ifndef CONFIG_PPC64
-	STACK_PT_REGS_OFFSET(GPR14, gpr[14]);
-#endif /* CONFIG_PPC64 */
 	/*
 	 * Note: these symbols include _ because they overlap with
special
 	 * register names

Re: [PATCH] powerpc/asm-offsets: GPR14 is not needed either

From: Michael Ellerman <hidden>
Date: 2021-03-31 01:11:01

On Mon, 15 Mar 2021 11:01:26 +0000 (UTC), Christophe Leroy wrote:
Commit aac6a91fea93 ("powerpc/asm: Remove unused symbols in
asm-offsets.c") removed GPR15 to GPR31 but kept GPR14,
probably because it pops up in a couple of comments when doing
a grep.

However, it was never used either, so remove it as well.
Applied to powerpc/next.

[1/1] powerpc/asm-offsets: GPR14 is not needed either
      https://git.kernel.org/powerpc/c/6eeca7a11379e9dd05493bbdba57515b36a2e3cf

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help