[PATCH] scsi: ibmvscsi: delete the useless casting value returned

Subsystems: ibm power virtual scsi device drivers, linux for powerpc (32-bit and 64-bit), scsi subsystem, the rest

STALE1983d LANDED

Landed in mainline as 0d556a21a9da on 2021-03-25.

2 messages, 2 authors, 2021-03-30 · open the first message on its own page

[PATCH] scsi: ibmvscsi: delete the useless casting value returned

From: Wang Qing <hidden>
Date: 2021-03-12 02:20:05

Fix the following coccicheck warning:
WARNING: casting value returned by memory allocation function is useless.

Signed-off-by: Wang Qing <redacted>
---
 drivers/scsi/ibmvscsi/ibmvscsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 29fcc44..f084ca10
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -717,8 +717,7 @@ static int map_sg_data(struct scsi_cmnd *cmd,
 
 	/* get indirect table */
 	if (!evt_struct->ext_list) {
-		evt_struct->ext_list = (struct srp_direct_buf *)
-			dma_alloc_coherent(dev,
+		evt_struct->ext_list = dma_alloc_coherent(dev,
 					   SG_ALL * sizeof(struct srp_direct_buf),
 					   &evt_struct->ext_list_token, 0);
 		if (!evt_struct->ext_list) {
-- 
2.7.4

Re: [PATCH] scsi: ibmvscsi: delete the useless casting value returned

From: Martin K. Petersen <hidden>
Date: 2021-03-30 03:57:17

On Fri, 12 Mar 2021 10:18:53 +0800, Wang Qing wrote:
Fix the following coccicheck warning:
WARNING: casting value returned by memory allocation function is useless.
Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: ibmvscsi: delete the useless casting value returned
      https://git.kernel.org/mkp/scsi/c/0d556a21a9da

-- 
Martin K. Petersen	Oracle Linux Engineering
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help