# Re: \[PATCH v5 05/10\] powerpc/signal64: Remove TM ifdefery in middle of if/else block

- From: Michael Ellerman \<mpe@ellerman.id.au\>
- Date: 2021-02-18 10:47:35 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2021/02/9520972
- Thread: https://ratatoskr.run/linuxppc-dev/2021/02/9520770/t.md

```text
"Christopher M. Riedl" [ref] writes:
> On Thu Feb 11, 2021 at 11:21 PM CST, Daniel Axtens wrote:
...
>>
>> My only concern here was whether it was valid to access
>> if (__get_user(msr, &uc->uc_mcontext.gp_regs[PT_MSR]))
>> if CONFIG_PPC_TRANSACTIONAL_MEM was not defined, but I didn't think of
>> any obvious reason why it wouldn't be...
>
> Hmm, we don't really need it for the non-TM case and it is another extra
> uaccess. I will take your suggestion to remove the need for the other
> ifdefs but might keep this one. Keeping it also makes it very clear this
> call is only here for TM and possible to remove in a potentially TM-less
> future :)

Yep I agree.

cheers
```