[PATCH] powerpc/eeh: remove unneeded semicolon

Subsystems: linux for powerpc (32-bit and 64-bit), pci enhanced error handling (eeh) for powerpc, the rest

STALE1931d LANDED

Landed in mainline as f3d03fc748d4 on 2021-04-22.

3 messages, 3 authors, 2021-04-29 · open the first message on its own page

[PATCH] powerpc/eeh: remove unneeded semicolon

From: Yang Li <hidden>
Date: 2021-02-02 03:22:36

Eliminate the following coccicheck warning:
./arch/powerpc/kernel/eeh.c:782:2-3: Unneeded semicolon

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
 arch/powerpc/kernel/eeh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index 813713c..02c058d 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -779,7 +779,7 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state stat
 	default:
 		eeh_pe_state_clear(pe, EEH_PE_ISOLATED | EEH_PE_CFG_BLOCKED, true);
 		return -EINVAL;
-	};
+	}
 
 	return 0;
 }
-- 
1.8.3.1

Re: [PATCH] powerpc/eeh: remove unneeded semicolon

From: "Oliver O'Halloran" <oohall@gmail.com>
Date: 2021-02-02 03:45:03

On Tue, Feb 2, 2021 at 2:21 PM Yang Li [off-list ref] wrote:
Eliminate the following coccicheck warning:
./arch/powerpc/kernel/eeh.c:782:2-3: Unneeded semicolon
Doesn't appear to be a load-bearing semicolon. It's hard to tell with EEH.

Reviewed-by: Oliver O'Halloran <oohall@gmail.com>
quoted hunk
Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
 arch/powerpc/kernel/eeh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index 813713c..02c058d 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -779,7 +779,7 @@ int pcibios_set_pcie_reset_state(struct pci_dev *dev, enum pcie_reset_state stat
        default:
                eeh_pe_state_clear(pe, EEH_PE_ISOLATED | EEH_PE_CFG_BLOCKED, true);
                return -EINVAL;
-       };
+       }

        return 0;
 }
--
1.8.3.1

Re: [PATCH] powerpc/eeh: remove unneeded semicolon

From: Michael Ellerman <hidden>
Date: 2021-04-29 14:03:03

On Tue, 2 Feb 2021 11:21:36 +0800, Yang Li wrote:
Eliminate the following coccicheck warning:
./arch/powerpc/kernel/eeh.c:782:2-3: Unneeded semicolon
Applied to powerpc/next.

[1/1] powerpc/eeh: remove unneeded semicolon
      https://git.kernel.org/powerpc/c/f3d03fc748d4e48f4cd8dea1bfeb173cb3b0c19f

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help