# Re: \[PATCH v2 0/3\] PPC: Fix -Wimplicit-fallthrough for clang

- From: Gustavo A. R. Silva \<gustavoars@kernel.org\>
- Date: 2020-11-18 20:28:11 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/11/6181849
- Thread: https://ratatoskr.run/linuxppc-dev/2020/11/6180823/t.md

```text
Nick,

On Tue, Nov 17, 2020 at 04:07:48PM -0800, Nick Desaulniers wrote:
> While cleaning up the last few -Wimplicit-fallthrough warnings in tree
> for Clang, I noticed
> commit 6a9dc5fd6170d ("lib: Revert use of fallthrough pseudo-keyword in lib/")
> which seemed to undo a bunch of fixes in lib/ due to breakage in
> arch/powerpc/boot/ not including compiler_types.h.  We don't need
> compiler_types.h for the definition of `fallthrough`, simply
> compiler_attributes.h.  Include that, revert the revert to lib/, and fix
> the last remaining cases I observed for powernv_defconfig.

I've added the series to my -next tree, together with Miguel's
suggestions.

Thanks for the Acks and comments, Michael.

--
Gustavo
```
