[PATCH -next] drivers/macintosh/smu.c: Fix undeclared symbol warning

Subsystems: linux for power macintosh, the rest

STALE2155d LANDED

Landed in mainline as 3db8715ec9dc on 2020-09-16.

2 messages, 2 authors, 2020-09-17 · open the first message on its own page

[PATCH -next] drivers/macintosh/smu.c: Fix undeclared symbol warning

From: Wang Wensheng <hidden>
Date: 2020-09-14 17:24:17

Make kernel with `C=2`:
drivers/macintosh/smu.c:1018:30: warning: symbol
'__smu_get_sdb_partition' was not declared. Should it be static?

Reported-by: Hulk Robot <redacted>
Signed-off-by: Wang Wensheng <redacted>
---
 drivers/macintosh/smu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
index 96684581a25d..bae94caaad5c 100644
--- a/drivers/macintosh/smu.c
+++ b/drivers/macintosh/smu.c
@@ -1015,7 +1015,7 @@ static struct smu_sdbp_header *smu_create_sdb_partition(int id)
 /* Note: Only allowed to return error code in pointers (using ERR_PTR)
  * when interruptible is 1
  */
-const struct smu_sdbp_header *__smu_get_sdb_partition(int id,
+static const struct smu_sdbp_header *__smu_get_sdb_partition(int id,
 		unsigned int *size, int interruptible)
 {
 	char pname[32];
-- 
2.25.0

Re: [PATCH -next] drivers/macintosh/smu.c: Fix undeclared symbol warning

From: Michael Ellerman <hidden>
Date: 2020-09-17 11:32:40

On Mon, 14 Sep 2020 12:26:15 +0000, Wang Wensheng wrote:
Make kernel with `C=2`:
drivers/macintosh/smu.c:1018:30: warning: symbol
'__smu_get_sdb_partition' was not declared. Should it be static?
Applied to powerpc/next.

[1/1] drivers/macintosh/smu.c: Fix undeclared symbol warning
      https://git.kernel.org/powerpc/c/3db8715ec9dc1d32ecafc67af9fb96508c98efe5

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help