# Re: \[trivial PATCH\] treewide: Convert switch/case fallthrough; to break;

- From: Wolfram Sang \<wsa@kernel.org\>
- Date: 2020-09-10 06:53:27 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/09/6100077
- Thread: https://ratatoskr.run/linux-arm-kernel/2020/09/6099701/t.md

```text

> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index e32ef3f01fe8..b13b1cbcac29 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
>  		fallthrough;
>  	case PCI_DEVICE_ID_INTEL_82801CA_3:
>  		priv->features |= FEATURE_HOST_NOTIFY;
> -		fallthrough;
> +		break;
>  	case PCI_DEVICE_ID_INTEL_82801BA_2:
>  	case PCI_DEVICE_ID_INTEL_82801AB_3:
>  	case PCI_DEVICE_ID_INTEL_82801AA_3:

I am not the maintainer (Jean is) but I suggest to drop this hunk. The
code is more complex with multiple 'fallthrough', so this change alone
actually makes the code inconsistent. A rework would need a seperate
patch.

```

## Attachments

- [signature.asc](https://ratatoskr.run/linuxppc-dev/2020/09/6100077/attachment/0) (application/pgp-signature, 833 bytes)