# Re: \[PATCH 02/11\] mm: call import\_iovec() instead of rw\_copy\_check\_uvector() in process\_vm\_rw()

- From: Matthew Wilcox \<willy@infradead.org\>
- Date: 2020-09-21 14:48:22 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/09/189274
- Thread: https://ratatoskr.run/linux-arm-kernel/2020/09/189245/t.md

```text
On Mon, Sep 21, 2020 at 04:34:25PM +0200, Christoph Hellwig wrote:
>  {
> -	WARN_ON(direction & ~(READ | WRITE));
> +	WARN_ON(direction & ~(READ | WRITE | CHECK_IOVEC_ONLY));

This is now a no-op because:

include/linux/fs.h:#define CHECK_IOVEC_ONLY -1

I'd suggest we renumber it to 2?

(READ is 0, WRITE is 1.  This WARN_ON should probably be
	WARN_ON(direction > CHECK_IOVEC_ONLY)
```
