[PATCH] powerpc:entry_32: correct the path and function name in the comment

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE1605d

3 messages, 2 authors, 2022-03-15 · open the first message on its own page

[PATCH] powerpc:entry_32: correct the path and function name in the comment

From: chenzefeng <hidden>
Date: 2020-08-07 10:20:10

Update the comment for file's directory and function name changed.

Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")

Signed-off-by: chenzefeng <redacted>
---
 arch/powerpc/kernel/entry_32.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index 8420abd4ea1c..9937593d3a33 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S

@@ -696,8 +696,8 @@ handle_dabr_fault:
  * to the "_switch" path.  If you change this , you'll have to
  * change the fork code also.
  *
- * The code which creates the new task context is in 'copy_thread'
- * in arch/ppc/kernel/process.c
+ * The code which creates the new task context is in 'copy_thread_tls'
+ * in arch/powerpc/kernel/process.c
  */
 _GLOBAL(_switch)
 	stwu	r1,-INT_FRAME_SIZE(r1)

-- 
2.12.3

Re: [PATCH] powerpc:entry_32: correct the path and function name in the comment

From: Christophe Leroy <hidden>
Date: 2020-08-07 14:53:55


Le 07/08/2020 à 12:19, chenzefeng a écrit :

quoted hunk

Update the comment for file's directory and function name changed.

Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")

Signed-off-by: chenzefeng <redacted>
---
  arch/powerpc/kernel/entry_32.S | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index 8420abd4ea1c..9937593d3a33 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S

@@ -696,8 +696,8 @@ handle_dabr_fault:
   * to the "_switch" path.  If you change this , you'll have to
   * change the fork code also.
   *
- * The code which creates the new task context is in 'copy_thread'
- * in arch/ppc/kernel/process.c
+ * The code which creates the new task context is in 'copy_thread_tls'
+ * in arch/powerpc/kernel/process.c

Does it matters at all where the function is ? I'm sure people can find 
it themselves.

Christophe

   */
  _GLOBAL(_switch)
  	stwu	r1,-INT_FRAME_SIZE(r1)

Re: [PATCH] powerpc:entry_32: correct the path and function name in the comment

From: Christophe Leroy <hidden>
Date: 2022-03-15 09:58:20


Le 07/08/2020 à 12:19, chenzefeng a écrit :

Update the comment for file's directory and function name changed.

The function name changed again with commit 714acdbd1c94 ("arch: rename 
copy_thread_tls() back to copy_thread()")

Please update the patch to just drop the file name. Users are able to 
find where the function is by themselves.

Thanks
Christophe

quoted hunk

Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")

Signed-off-by: chenzefeng <redacted>
---
  arch/powerpc/kernel/entry_32.S | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index 8420abd4ea1c..9937593d3a33 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S

@@ -696,8 +696,8 @@ handle_dabr_fault:
   * to the "_switch" path.  If you change this , you'll have to
   * change the fork code also.
   *
- * The code which creates the new task context is in 'copy_thread'
- * in arch/ppc/kernel/process.c
+ * The code which creates the new task context is in 'copy_thread_tls'
+ * in arch/powerpc/kernel/process.c
   */
  _GLOBAL(_switch)
  	stwu	r1,-INT_FRAME_SIZE(r1)

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help