# Re: \[PATCH 14/15\] x86/numa: remove redundant iteration over memblock.reserved

- From: Mike Rapoport \<rppt@kernel.org\>
- Date: 2020-07-28 10:56:21 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/07/6052823
- Thread: https://ratatoskr.run/linux-arm-kernel/2020/07/6052438/t.md

```text
On Tue, Jul 28, 2020 at 12:44:40PM +0200, Ingo Molnar wrote:
> 
> * Mike Rapoport [ref] wrote:
> 
> > From: Mike Rapoport <redacted>
> > 
> > numa_clear_kernel_node_hotplug() function first traverses numa_meminfo
> > regions to set node ID in memblock.reserved and than traverses
> > memblock.reserved to update reserved_nodemask to include node IDs that were
> > set in the first loop.
> > 
> > Remove redundant traversal over memblock.reserved and update
> > reserved_nodemask while iterating over numa_meminfo.
> > 
> > Signed-off-by: Mike Rapoport <redacted>
> > ---
> >  arch/x86/mm/numa.c | 26 ++++++++++----------------
> >  1 file changed, 10 insertions(+), 16 deletions(-)
> 
> I suspect you'd like to carry this in the -mm tree?

Yes.
 
> Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks!

> Thanks,
> 
> 	Ingo

-- 
Sincerely yours,
Mike.
```
