[PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note

Subsystems: cell broadband engine architecture, linux for powerpc (32-bit and 64-bit), spu file system, the rest

STALE2206d LANDED

Landed in mainline as 7c7ff885c7bc on 2020-07-23.

2 messages, 2 authors, 2020-07-24 · open the first message on its own page

[PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note

From: Christoph Hellwig <hch@lst.de>
Date: 2020-06-10 09:00:12

Both the ->dump method and snprintf return an int.  So switch to an
int and properly handle errors from ->dump.

Fixes: 5456ffdee666 ("powerpc/spufs: simplify spufs core dumping")
Reported-by: kbuild test robot <redacted>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/powerpc/platforms/cell/spufs/coredump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c
index 3b75e8f60609cb..014d1c045bc3cf 100644
--- a/arch/powerpc/platforms/cell/spufs/coredump.c
+++ b/arch/powerpc/platforms/cell/spufs/coredump.c
@@ -105,7 +105,7 @@ static int spufs_arch_write_note(struct spu_context *ctx, int i,
 	size_t sz = spufs_coredump_read[i].size;
 	char fullname[80];
 	struct elf_note en;
-	size_t ret;
+	int ret;
 
 	sprintf(fullname, "SPU/%d/%s", dfd, spufs_coredump_read[i].name);
 	en.n_namesz = strlen(fullname) + 1;
-- 
2.26.2

Re: [PATCH] powerpc/spufs: fix the type of ret in spufs_arch_write_note

From: Michael Ellerman <hidden>
Date: 2020-07-24 14:42:48

On Wed, 10 Jun 2020 10:55:54 +0200, Christoph Hellwig wrote:
Both the ->dump method and snprintf return an int.  So switch to an
int and properly handle errors from ->dump.
Applied to powerpc/next.

[1/1] powerpc/spufs: Fix the type of ret in spufs_arch_write_note
      https://git.kernel.org/powerpc/c/7c7ff885c7bce40a487e41c68f1dac14dd2c8033

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help