# Re: rename -\>make\_request\_fn and move it to the block\_device\_operations

- From: Christoph Hellwig \<hch@lst.de\>
- Date: 2020-06-30 18:19:36 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/06/6020698
- Thread: https://ratatoskr.run/linuxppc-dev/2020/06/6018213/t.md

```text
On Tue, Jun 30, 2020 at 09:43:31AM -0600, Jens Axboe wrote:
> On 6/30/20 7:57 AM, Jens Axboe wrote:
> > On 6/29/20 1:39 PM, Christoph Hellwig wrote:
> >> Hi Jens,
> >>
> >> this series moves the make_request_fn method into block_device_operations
> >> with the much more descriptive ->submit_bio name.  It then also gives
> >> generic_make_request a more descriptive name, and further optimize the
> >> path to issue to blk-mq, removing the need for the direct_make_request
> >> bypass.
> > 
> > Looks good to me, and it's a nice cleanup as well. Applied.
> 
> Dropped, insta-crashes with dm:

Hmm.  Can you send me what is at "submit_bio_noacct+0x1f6" from gdb?
Or your .config?
```
