Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2 messages, 2 authors, 2020-06-23 · open the first message on its own page

Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

From: Markus Elfring <hidden>
Date: 2020-06-22 16:07:50

Fix unchecked return value for clk_prepare_enable.

And because clk_prepare_enable and clk_disable_unprepare should
check input clock parameter is NULL or not, then we don't need
to check it before calling the function.
I propose to split the adjustment of two function implementations
into separate update steps for a small patch series.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n138

I suggest to improve the change descriptions accordingly.

Regards,
Markus

Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2020-06-23 05:13:43

On Tue, Jun 23, 2020 at 12:08 AM Markus Elfring [off-list ref] wrote:
quoted
Fix unchecked return value for clk_prepare_enable.

And because clk_prepare_enable and clk_disable_unprepare should
check input clock parameter is NULL or not, then we don't need
to check it before calling the function.
I propose to split the adjustment of two function implementations
into separate update steps for a small patch series.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n138

I suggest to improve the change descriptions accordingly.
ok, will update the patches in v2.

best regards
wang shengjiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help