[PATCH] powerpc: Fix misleading small cores print

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2247d LANDED

Landed in mainline as 82a7cebdd95c on 2020-06-02.

3 messages, 3 authors, 2020-06-09 · open the first message on its own page

[PATCH] powerpc: Fix misleading small cores print

From: Michael Neuling <hidden>
Date: 2020-05-28 23:09:17

Currently when we boot on a big core system, we get this print:
  [    0.040500] Using small cores at SMT level

This is misleading as we've actually detected big cores.

This patch clears up the print to say we've detect big cores but are
using small cores for scheduling.

Signed-off-by: Michael Neuling <redacted>
---
 arch/powerpc/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 6d2a3a3666..c820c95162 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
 
 #ifdef CONFIG_SCHED_SMT
 	if (has_big_cores) {
-		pr_info("Using small cores at SMT level\n");
+		pr_info("Big cores detected but using small core scheduling\n");
 		power9_topology[0].mask = smallcore_smt_mask;
 		powerpc_topology[0].mask = smallcore_smt_mask;
 	}
-- 
2.26.2

Re: [PATCH] powerpc: Fix misleading small cores print

From: Gautham R Shenoy <hidden>
Date: 2020-06-02 14:58:22

On Fri, May 29, 2020 at 09:07:31AM +1000, Michael Neuling wrote:
Currently when we boot on a big core system, we get this print:
  [    0.040500] Using small cores at SMT level

This is misleading as we've actually detected big cores.

This patch clears up the print to say we've detect big cores but are
using small cores for scheduling.
Thanks for making the print more meaningful.

Signed-off-by: Michael Neuling <redacted>
FWIW,
Acked-by: Gautham R. Shenoy <redacted>
quoted hunk
---
 arch/powerpc/kernel/smp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 6d2a3a3666..c820c95162 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -1383,7 +1383,7 @@ void __init smp_cpus_done(unsigned int max_cpus)

 #ifdef CONFIG_SCHED_SMT
 	if (has_big_cores) {
-		pr_info("Using small cores at SMT level\n");
+		pr_info("Big cores detected but using small core scheduling\n");
 		power9_topology[0].mask = smallcore_smt_mask;
 		powerpc_topology[0].mask = smallcore_smt_mask;
 	}
-- 
2.26.2

Re: [PATCH] powerpc: Fix misleading small cores print

From: Michael Ellerman <hidden>
Date: 2020-06-09 06:18:00

On Fri, 29 May 2020 09:07:31 +1000, Michael Neuling wrote:
Currently when we boot on a big core system, we get this print:
  [    0.040500] Using small cores at SMT level

This is misleading as we've actually detected big cores.

This patch clears up the print to say we've detect big cores but are
using small cores for scheduling.
Applied to powerpc/next.

[1/1] powerpc: Fix misleading small cores print
      https://git.kernel.org/powerpc/c/82a7cebdd95cffa55449d6c1d97cc9b743a66056

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help