[PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED

STALE2279d

2 messages, 2 authors, 2020-05-08 · open the first message on its own page

[PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED

From: Darren Stevens <hidden>
Date: 2020-05-07 21:37:24

The Cyrus board has its HDD LED connected to a GPIO pin. Add a device
tree entry for this.

Signed-off-By: Darren Stevens <redacted>

---
 arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f
100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
+++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
@@ -83,6 +83,16 @@
 			gpios = <&gpio0 2 1>;
 		};
 
+		leds {
+			compatible = "gpio-leds";
+
+			hdd {
+				label = "Disk Activity";
+				gpios = <&gpio0 5 0>;
+				linux,default-trigger =
"disk-activity";
+			};
+		};
+
 		fman@400000 {
 			mdio@e1120 {
 				phy3: ethernet-phy@3 {

Re: [PATCH 4/5] powerpc/mpc85xx: Add Cyrus HDD LED

From: Scott Wood <oss@buserror.net>
Date: 2020-05-08 20:42:38

On Thu, 2020-05-07 at 22:15 +0100, Darren Stevens wrote:
quoted hunk
The Cyrus board has its HDD LED connected to a GPIO pin. Add a device
tree entry for this.

Signed-off-By: Darren Stevens <redacted>

---
 arch/powerpc/boot/dts/fsl/cyrus_p5020.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts index f0548fe..74c100f
100644 --- a/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
+++ b/arch/powerpc/boot/dts/fsl/cyrus_p5020.dts
@@ -83,6 +83,16 @@
 			gpios = <&gpio0 2 1>;
 		};
 
+		leds {
+			compatible = "gpio-leds";
+
+			hdd {
+				label = "Disk Activity";
+				gpios = <&gpio0 5 0>;
+				linux,default-trigger =
"disk-activity";
+			};
Documentation/devicetree/bindings/leds/common.yaml says that label is
deprecated, and to "use 'function' and 'color' properties instead".

Also, please CC devicetree@vger.kernel.org on these patches.

-Scott

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help