From: Biwen Li <redacted>
Add uie_unsupported property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-liux: select() /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1374's INT pin is connected to VCC on T4240RDB,
then the RTC cannot inform cpu about the alarm
interrupt
Signed-off-by: Biwen Li <redacted>
---
drivers/rtc/rtc-ds1374.c | 4 ++++
1 file changed, 4 insertions(+)
From: Biwen Li <redacted>
This adds uie_unsupported property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-linux: select() to /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1374's INT pin is connected to VCC on T4240RDB,
then the RTC cannot inform cpu about the alarm interrupt
Signed-off-by: Biwen Li <redacted>
---
arch/powerpc/boot/dts/fsl/t4240rdb.dts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
@@ -144,7 +144,11 @@rtc@68{compatible="dallas,ds1374";reg=<0x68>;-interrupts=<0x10x100>;+// The ds1374's INT pin isn't+// connected to cpu's INT pin,+// so the rtc cannot synchronize+// clock tick per second.+uie_unsupported;};};
From: Biwen Li <redacted>
This adds wakeup-source property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-linux: select() to /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1339s INT pin isn't connected to cpus INT pin on T1024RDB,
then the RTC cannot inform cpu about alarm interrupt
How to fix it?
- add wakeup-source property and remove IRQ line
to set uie_unsupported flag
Signed-off-by: Biwen Li <redacted>
---
arch/powerpc/boot/dts/fsl/t1024rdb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Biwen Li <redacted>
Add uie_unsupported property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-liux: select() /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1374's INT pin is connected to VCC on T4240RDB,
then the RTC cannot inform cpu about the alarm
interrupt
Signed-off-by: Biwen Li <redacted>
---
drivers/rtc/rtc-ds1374.c | 4 ++++
1 file changed, 4 insertions(+)
@@ -651,6 +651,10 @@ static int ds1374_probe(struct i2c_client *client,if(ret)returnret;+if(of_property_read_bool(client->dev.of_node,+"uie_unsupported"))+ds1374->rtc->uie_unsupported=true;+
This is not how this is supposed to work, either the RTC support uie or
don't, it is not board dependent and certainly doesn't require an
(undocumented) DT property.
#ifdef CONFIG_RTC_DRV_DS1374_WDT
save_client = client;
ret = misc_register(&ds1374_miscdev);
--
2.17.1
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
From: Biwen Li <redacted>
This adds uie_unsupported property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-linux: select() to /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1374's INT pin is connected to VCC on T4240RDB,
then the RTC cannot inform cpu about the alarm interrupt
Signed-off-by: Biwen Li <redacted>
---
arch/powerpc/boot/dts/fsl/t4240rdb.dts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
removing the interrupt should be enough to solve your issue
+ // The ds1374's INT pin isn't
+ // connected to cpu's INT pin,
+ // so the rtc cannot synchronize
+ // clock tick per second.
+ uie_unsupported;
};
};
--
2.17.1
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
From: Biwen Li (OSS) <hidden> Date: 2020-05-08 11:59:07
Hi,
On 08/05/2020 13:49:23+0800, Biwen Li wrote:
quoted
From: Biwen Li <redacted>
Add uie_unsupported property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-liux: select() /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1374's INT pin is connected to VCC on T4240RDB,
then the RTC cannot inform cpu about the alarm
interrupt
Signed-off-by: Biwen Li <redacted>
---
drivers/rtc/rtc-ds1374.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index
@@ -651,6 +651,10 @@ static int ds1374_probe(struct i2c_client *client,if(ret)returnret;+if(of_property_read_bool(client->dev.of_node,+"uie_unsupported"))+ds1374->rtc->uie_unsupported=true;+
This is not how this is supposed to work, either the RTC support uie or don't, it is
not board dependent and certainly doesn't require an
(undocumented) DT property.
Okay, got it. Thanks.
quoted
#ifdef CONFIG_RTC_DRV_DS1374_WDT
save_client = client;
ret = misc_register(&ds1374_miscdev);
--
2.17.1
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
From: Biwen Li (OSS) <hidden> Date: 2020-05-08 11:59:48
On 08/05/2020 13:49:24+0800, Biwen Li wrote:
quoted
From: Biwen Li <redacted>
This adds uie_unsupported property to drop warning as follows:
- $ hwclock.util-linux
hwclock.util-linux: select() to /dev/rtc0
to wait for clock tick timed out
My case:
- RTC ds1374's INT pin is connected to VCC on T4240RDB,
then the RTC cannot inform cpu about the alarm interrupt
Signed-off-by: Biwen Li <redacted>
---
arch/powerpc/boot/dts/fsl/t4240rdb.dts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
removing the interrupt should be enough to solve your issue
Okay, got it. Thanks.
quoted
+ // The ds1374's INT pin isn't
+ // connected to cpu's INT pin,
+ // so the rtc cannot synchronize
+ // clock tick per second.
+ uie_unsupported;
};
};
--
2.17.1
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com