# Re: \[PATCH 6/8\] simplefs: add file creation functions

- From: Greg Kroah-Hartman \<gregkh@linuxfoundation.org\>
- Date: 2020-04-14 12:56:31 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/04/6499378
- Thread: https://ratatoskr.run/linuxppc-dev/2020/04/6499367/t.md

```text
On Tue, Apr 14, 2020 at 02:43:00PM +0200, Emanuele Giuseppe Esposito wrote:
> A bunch of code is duplicated between debugfs and tracefs, unify it to the
> simplefs library.
> 
> The code is very similar, except that dentry and inode creation are unified
> into a single function (unlike start_creating in debugfs and tracefs, which
> only takes care of dentries).  This adds an output parameter to the creation
> functions, but pushes all error recovery into fs/simplefs.c.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <redacted>
> ---
>  fs/simplefs.c            | 150 +++++++++++++++++++++++++++++++++++++++
>  include/linux/simplefs.h |  19 +++++
>  2 files changed, 169 insertions(+)

What's wrong with libfs, isn't that supposed to be for these types of
"common" filesystem interactions?

Why create a whole "new" fs for this?

thanks,

greg k-h
```