[PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

Subsystems: the rest, tpm device driver

STALE2352d

8 messages, 4 authors, 2020-03-19 · open the first message on its own page

[PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Stefan Berger <hidden>
Date: 2020-03-17 13:09:42

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 drivers/char/tpm/tpm2-cmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c
index 76f67b155bd5..eff1f12d981a 100644
--- a/drivers/char/tpm/tpm2-cmd.c
+++ b/drivers/char/tpm/tpm2-cmd.c

@@ -681,6 +681,7 @@ int tpm2_get_cc_attrs_tbl(struct tpm_chip *chip)
 		rc = -ENODEV;
 	return rc;
 }
+EXPORT_SYMBOL_GPL(tpm2_get_cc_attrs_tbl);
 
 /**
  * tpm2_startup - turn on the TPM

-- 
2.23.0

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Sachin Sant <hidden>
Date: 2020-03-17 15:22:17

On 17-Mar-2020, at 6:38 PM, Stefan Berger [off-list ref] wrote:

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Reported-by: Sachin Sant <redacted>
Tested-by: Sachin Sant <redacted>

Thanks
-Sachin

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Stefan Berger <stefanb@linux.ibm.com>
Date: 2020-03-17 15:31:13

On 3/17/20 11:22 AM, Sachin Sant wrote:

quoted

On 17-Mar-2020, at 6:38 PM, Stefan Berger [off-list ref] wrote:

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Reported-by: Sachin Sant <redacted>
Tested-by: Sachin Sant <redacted>

Thank you!

    Stefan

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Jarkko Sakkinen <hidden>
Date: 2020-03-18 19:42:55

On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote:

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable.
Thanks.

/Jarkko

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Stefan Berger <stefanb@linux.ibm.com>
Date: 2020-03-18 19:54:07

On 3/18/20 3:42 PM, Jarkko Sakkinen wrote:

On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote:

quoted

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable.
Thanks.

I did not add the fixes tag because I do not know the final commit hash, 
or is it the final commit hash once it is in linux-next? I doubt it with 
all the merging that can occur.


    Stefan

/Jarkko

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Jarkko Sakkinen <hidden>
Date: 2020-03-19 14:27:21

On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote:

On 3/18/20 3:42 PM, Jarkko Sakkinen wrote:

quoted

On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote:

quoted

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable.
Thanks.

I did not add the fixes tag because I do not know the final commit hash, or
is it the final commit hash once it is in linux-next? I doubt it with all
the merging that can occur.

Can you send me a new version after rc1 is out?

/Jarkko

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Stefan Berger <stefanb@linux.ibm.com>
Date: 2020-03-19 15:56:27

On 3/19/20 10:27 AM, Jarkko Sakkinen wrote:

On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote:

quoted

On 3/18/20 3:42 PM, Jarkko Sakkinen wrote:

quoted

On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote:

quoted

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable.
Thanks.

I did not add the fixes tag because I do not know the final commit hash, or
is it the final commit hash once it is in linux-next? I doubt it with all
the merging that can occur.

Can you send me a new version after rc1 is out?

Michael Ellerman (cc'ed) told me that the fixes tag should 'work' once 
the bad patch is in linux-next. So I reposted yesterday (with a stray 
'q' in the title :-( ):

https://lkml.org/lkml/2020/3/18/1283


    Stefan

/Jarkko

Re: [PATCH] tpm2: Export tpm2_get_cc_attrs_tbl for ibmvtpm driver as module

From: Jarkko Sakkinen <hidden>
Date: 2020-03-19 21:16:47

On Thu, Mar 19, 2020 at 11:56:11AM -0400, Stefan Berger wrote:

On 3/19/20 10:27 AM, Jarkko Sakkinen wrote:

quoted

On Wed, Mar 18, 2020 at 03:53:54PM -0400, Stefan Berger wrote:

quoted

On 3/18/20 3:42 PM, Jarkko Sakkinen wrote:

quoted

On Tue, Mar 17, 2020 at 09:08:19AM -0400, Stefan Berger wrote:

quoted

From: Stefan Berger <stefanb@linux.ibm.com>

This patch fixes the following problem when the ibmvtpm driver
is built as a module:

ERROR: modpost: "tpm2_get_cc_attrs_tbl" [drivers/char/tpm/tpm_ibmvtpm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1298: modules] Error 2

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>

Hi, wrong tag (we use "tpm:"), missing fixes tag and please cc stable.
Thanks.

I did not add the fixes tag because I do not know the final commit hash, or
is it the final commit hash once it is in linux-next? I doubt it with all
the merging that can occur.

Can you send me a new version after rc1 is out?

Michael Ellerman (cc'ed) told me that the fixes tag should 'work' once the
bad patch is in linux-next. So I reposted yesterday (with a stray 'q' in the
title :-( ):

OK, cool, I'll correct it and apply thanks.

Reviewed-by: Jarkko Sakkinen <redacted>

/Jarkko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help