[PATCH] powerpc: Fix /proc/cpuinfo revision for POWER9P processors

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2370d

3 messages, 2 authors, 2020-02-17 · open the first message on its own page

[PATCH] powerpc: Fix /proc/cpuinfo revision for POWER9P processors

From: Mahesh Salgaonkar <hidden>
Date: 2020-02-13 16:36:49

POWER9P PVR bits are same as that of POWER9. Hence mask off only the
relevant bits for the major revision similar to POWER9.

Without this patch the cpuinfo output shows 17.0 as revision:

$ cat /proc/cpuinfo
processor	: 0
cpu		: POWER9P, altivec supported
clock		: 2950.000000MHz
revision	: 17.0 (pvr 004f 1100)

With this change it reflects the correct revision:

$ cat /proc/cpuinfo
processor	: 0
cpu		: POWER9P, altivec supported
clock		: 2633.000000MHz
revision	: 1.0 (pvr 004f 1100)

Signed-off-by: Mahesh Salgaonkar <redacted>
---
 arch/powerpc/kernel/setup-common.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 488f1eecc0de..37342ec42cb3 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -315,6 +315,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
 				min = pvr & 0xFF;
 				break;
 			case 0x004e: /* POWER9 bits 12-15 give chip type */
+			case 0x004f: /* POWER9P bits 12-15 give chip type */
 				maj = (pvr >> 8) & 0x0F;
 				min = pvr & 0xFF;
 				break;

Re: [PATCH] powerpc: Fix /proc/cpuinfo revision for POWER9P processors

From: Leonardo Bras <hidden>
Date: 2020-02-15 06:24:51

Mahesh Salgaonkar [off-list ref] writes:

Hello Mahesh,
quoted hunk
POWER9P PVR bits are same as that of POWER9. Hence mask off only the
relevant bits for the major revision similar to POWER9.

Without this patch the cpuinfo output shows 17.0 as revision:

$ cat /proc/cpuinfo
processor     : 0
cpu           : POWER9P, altivec supported
clock         : 2950.000000MHz
revision      : 17.0 (pvr 004f 1100)

With this change it reflects the correct revision:

$ cat /proc/cpuinfo
processor     : 0
cpu           : POWER9P, altivec supported
clock         : 2633.000000MHz
revision      : 1.0 (pvr 004f 1100)

Signed-off-by: Mahesh Salgaonkar <redacted>
---
 arch/powerpc/kernel/setup-common.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 488f1eecc0de..37342ec42cb3 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -315,6 +315,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
                              min = pvr & 0xFF;
                              break;
                      case 0x004e: /* POWER9 bits 12-15 give chip type */
+                     case 0x004f: /* POWER9P bits 12-15 give chip type */
                              maj = (pvr >> 8) & 0x0F;
                              min = pvr & 0xFF;
                              break;
Seems fine to me.

FWIW:
Reviwed-by: Leonardo Bras [off-list ref]

Re: [PATCH] powerpc: Fix /proc/cpuinfo revision for POWER9P processors

From: Leonardo Bras <hidden>
Date: 2020-02-17 14:17:49

On Sat, 2020-02-15 at 03:23 -0300, Leonardo Bras wrote:
Mahesh Salgaonkar [off-list ref] writes:

Hello Mahesh,
quoted
POWER9P PVR bits are same as that of POWER9. Hence mask off only the
relevant bits for the major revision similar to POWER9.

Without this patch the cpuinfo output shows 17.0 as revision:

$ cat /proc/cpuinfo
processor     : 0
cpu           : POWER9P, altivec supported
clock         : 2950.000000MHz
revision      : 17.0 (pvr 004f 1100)

With this change it reflects the correct revision:

$ cat /proc/cpuinfo
processor     : 0
cpu           : POWER9P, altivec supported
clock         : 2633.000000MHz
revision      : 1.0 (pvr 004f 1100)

Signed-off-by: Mahesh Salgaonkar <redacted>
---
 arch/powerpc/kernel/setup-common.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 488f1eecc0de..37342ec42cb3 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -315,6 +315,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
                              min = pvr & 0xFF;
                              break;
                      case 0x004e: /* POWER9 bits 12-15 give chip type */
+                     case 0x004f: /* POWER9P bits 12-15 give chip type */
                              maj = (pvr >> 8) & 0x0F;
                              min = pvr & 0xFF;
                              break;
Seems fine to me.

FWIW:
Reviwed-by: Leonardo Bras [off-list ref]
Sorry, typo.
Reviewed-by: Leonardo Bras <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help