[PATCH] powerpc/papr_scm: Mark papr_scm_ndctl() as static

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2382d LANDED

Landed in mainline as 72c4ebbac476 on 2020-02-19.

2 messages, 2 authors, 2020-03-06 · open the first message on its own page

[PATCH] powerpc/papr_scm: Mark papr_scm_ndctl() as static

From: Vaibhav Jain <hidden>
Date: 2020-01-30 04:04:17

Function papr_scm_ndctl() is neither exported from the module nor
called directly from outside 'papr.c' hence should be marked 'static'.

Signed-off-by: Vaibhav Jain <redacted>
---
 arch/powerpc/platforms/pseries/papr_scm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c
index 0b4467e378e5..e4606100e286 100644
--- a/arch/powerpc/platforms/pseries/papr_scm.c
+++ b/arch/powerpc/platforms/pseries/papr_scm.c
@@ -246,8 +246,9 @@ static int papr_scm_meta_set(struct papr_scm_priv *p,
 	return 0;
 }
 
-int papr_scm_ndctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
-		unsigned int cmd, void *buf, unsigned int buf_len, int *cmd_rc)
+static int papr_scm_ndctl(struct nvdimm_bus_descriptor *nd_desc,
+			  struct nvdimm *nvdimm, unsigned int cmd, void *buf,
+			  unsigned int buf_len, int *cmd_rc)
 {
 	struct nd_cmd_get_config_size *get_size_hdr;
 	struct papr_scm_priv *p;
-- 
2.24.1

Re: [PATCH] powerpc/papr_scm: Mark papr_scm_ndctl() as static

From: Michael Ellerman <hidden>
Date: 2020-03-06 00:42:38

On Thu, 2020-01-30 at 04:02:06 UTC, Vaibhav Jain wrote:
Function papr_scm_ndctl() is neither exported from the module nor
called directly from outside 'papr.c' hence should be marked 'static'.

Signed-off-by: Vaibhav Jain <redacted>
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/72c4ebbac476b8375e69fd09390e6b64c2891716

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help