# Re: \[PATCH v2 2/9\] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

- From: Kalle Valo \<hidden\>
- Date: 2020-01-12 12:36:38 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/01/9177238
- Thread: https://ratatoskr.run/dri-devel/2020/01/5824889/t.md

```text
Krzysztof Kozlowski [ref] writes:

> The ioreadX() helpers have inconsistent interface.  On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> ---
>
> Changes since v1:
> 1. Add Geert's review.
> ---
>  drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8180.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

No need to have "net: wireless: " in the title, this is enough.

rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

I assume someone else will take this so here's my ack:

Acked-by: Kalle Valo <redacted>

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
```