# Re: \[PATCH v2 1/9\] iomap: Constify ioreadX() iomem argument (as in generic implementation)

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2020-01-09 12:00:54 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/01/9177150
- Thread: https://ratatoskr.run/dri-devel/2020/01/5824889/t.md

```text
On Wed, Jan 8, 2020 at 9:05 PM Krzysztof Kozlowski [ref] wrote:
> The ioreadX() and ioreadX_rep() helpers have inconsistent interface.  On
> some architectures void *__iomem address argument is a pointer to const,
> on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
```