# Re: \[RFT 00/13\] iomap: Constify ioreadX() iomem argument

- From: Krzysztof Kozlowski \<krzk@kernel.org\>
- Date: 2020-01-08 08:18:20 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/01/9177100
- Thread: https://ratatoskr.run/dri-devel/2020/01/5822989/t.md

```text
On Wed, 8 Jan 2020 at 09:13, Geert Uytterhoeven [ref] wrote:
>
> Hi Krzysztof,
>
> On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven [ref] wrote:
> > On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski [ref] wrote:
> > > The ioread8/16/32() and others have inconsistent interface among the
> > > architectures: some taking address as const, some not.
> > >
> > > It seems there is nothing really stopping all of them to take
> > > pointer to const.
> >
> > Shouldn't all of them take const volatile __iomem pointers?
> > It seems the "volatile" is missing from all but the implementations in
> > include/asm-generic/io.h.
>
> As my "volatile" comment applies to iowrite*(), too, probably that should be
> done in a separate patch.
>
> Hence with patches 1-5 squashed, and for patches 11-13:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

I'll add to this one also changes to ioreadX_rep() and add another
patch for volatile for reads and writes. I guess your review will be
appreciated once more because of ioreadX_rep()

Thanks,
Krzysztof
```