# Re: \[RFT 00/13\] iomap: Constify ioreadX() iomem argument

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2020-01-08 08:13:40 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/01/9177097
- Thread: https://ratatoskr.run/dri-devel/2020/01/5822989/t.md

```text
Hi Krzysztof,

On Wed, Jan 8, 2020 at 9:07 AM Geert Uytterhoeven [ref] wrote:
> On Tue, Jan 7, 2020 at 5:53 PM Krzysztof Kozlowski [ref] wrote:
> > The ioread8/16/32() and others have inconsistent interface among the
> > architectures: some taking address as const, some not.
> >
> > It seems there is nothing really stopping all of them to take
> > pointer to const.
>
> Shouldn't all of them take const volatile __iomem pointers?
> It seems the "volatile" is missing from all but the implementations in
> include/asm-generic/io.h.

As my "volatile" comment applies to iowrite*(), too, probably that should be
done in a separate patch.

Hence with patches 1-5 squashed, and for patches 11-13:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
```