# Re: \[RFT 03/13\] sh: Constify ioreadX() iomem argument (as in generic implementation)

- From: Arnd Bergmann \<arnd@arndb.de\>
- Date: 2020-01-07 17:08:40 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2020/01/9177069
- Thread: https://ratatoskr.run/dri-devel/2020/01/5822989/t.md

```text
On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski [ref] wrote:
>
> The ioreadX() helpers have inconsistent interface.  On some architectures
> void *__iomem address argument is a pointer to const, on some not.
>
> Implementations of ioreadX() do not modify the memory under the address
> so they can be converted to a "const" version for const-safety and
> consistency among architectures.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

The patch looks good, but I think this has to be done together with the powerpc
version and the header that declares the function, for bisectibility.

       Arnd
```