[PATCH] powerpc/ptdump: fix W+X verification call in mark_rodata_ro()

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE2414d LANDED

Landed in mainline as e26ad936dd89 on 2020-01-23.

2 messages, 2 authors, 2020-01-29 · open the first message on its own page

[PATCH] powerpc/ptdump: fix W+X verification call in mark_rodata_ro()

From: Christophe Leroy <hidden>
Date: 2020-01-14 08:13:12

ptdump_check_wx() also have to be called when pages are mapped
by blocks.

Signed-off-by: Christophe Leroy <redacted>
Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
---
 arch/powerpc/mm/pgtable_32.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c
index 73b84166d06a..5fb90edd865e 100644
--- a/arch/powerpc/mm/pgtable_32.c
+++ b/arch/powerpc/mm/pgtable_32.c
@@ -218,6 +218,7 @@ void mark_rodata_ro(void)
 
 	if (v_block_mapped((unsigned long)_sinittext)) {
 		mmu_mark_rodata_ro();
+		ptdump_check_wx();
 		return;
 	}
 
-- 
2.13.3

Re: [PATCH] powerpc/ptdump: fix W+X verification call in mark_rodata_ro()

From: Michael Ellerman <hidden>
Date: 2020-01-29 05:17:54

On Tue, 2020-01-14 at 08:13:08 UTC, Christophe Leroy wrote:
ptdump_check_wx() also have to be called when pages are mapped
by blocks.

Signed-off-by: Christophe Leroy <redacted>
Fixes: 453d87f6a8ae ("powerpc/mm: Warn if W+X pages found on boot")
Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e26ad936dd89d79f66c2b567f700e0c2a7103070

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help