# Re: \[PATCH v4 30/47\] serial: ucc\_uart: factor out soft\_uart initialization

- From: Timur Tabi \<timur@kernel.org\>
- Date: 2019-11-14 05:15:29 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/11/5776232
- Thread: https://ratatoskr.run/linuxppc-dev/2019/11/5769927/t.md

```text
On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes
[ref] wrote:
>
> -       /*
> -        * Determine if we need Soft-UART mode
> -        */
>         if (of_find_property(np, "soft-uart", NULL)) {
>                 dev_dbg(&ofdev->dev, "using Soft-UART mode\n");
>                 soft_uart = 1;
> +       } else {
> +               return 0;
>         }

How about:

if (!of_find_property(np, "soft-uart", NULL))
    return 0;

And I think you should be able to get rid of the "soft_uart" variable.
```