# Re: \[PATCH 0/3\] powerpc/ftrace: Enable HAVE\_FUNCTION\_GRAPH\_RET\_ADDR\_PTR

- From: Nicholas Piggin \<npiggin@gmail.com\>
- Date: 2019-09-08 10:26:45 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/09/5712246
- Thread: https://ratatoskr.run/linuxppc-dev/2019/09/5710612/t.md

```text
Naveen N. Rao's on September 6, 2019 4:20 am:
> Enable HAVE_FUNCTION_GRAPH_RET_ADDR_PTR for more robust stack unwinding 
> when function graph tracer is in use. Convert powerpc show_stack() to 
> use ftrace_graph_ret_addr() for better stack unwinding.

This series improved my case of a WARN_ON triggering in 
trace_graph_return, the last return_to_handler entry in the stack
dump has the caller in parenthesis rather than return_to_handler.

It gives the caller, it would be nice if it could output the actual
function being traced, and then continue the caller. But at least
this is a significant improvement. Thanks for the quick turnaround.

Tested-by: Nicholas Piggin <npiggin@gmail.com>

```
