# Re: \[PATCH v5 1/2\] powerpc/xmon: Allow listing and clearing breakpoints in read-only mode

- From: Daniel Axtens \<hidden\>
- Date: 2019-08-29 06:42:15 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/08/9511957
- Thread: https://ratatoskr.run/linuxppc-dev/2019/08/9511912/t.md

```text
Hi Chris,

> Read-only mode should not prevent listing and clearing any active
> breakpoints.

I tested this and it works for me:

Tested-by: Daniel Axtens <redacted>

> +		if (xmon_is_ro || !scanhex(&a)) {

It took me a while to figure out what this line does: as I understand
it, the 'b' command can also be used to install a breakpoint (as well as
bi/bd). If we are in ro mode or if the input after 'b' doesn't scan as a
hex string, print the list of breakpoints instead. Anyway, I'm now
happy with it, so:

Reviewed-by: Daniel Axtens <redacted>

Regards,
Daniel

>  			/* print all breakpoints */
>  			printf("   type            address\n");
>  			if (dabr.enabled) {
> -- 
> 2.23.0
```