Some user might want to go through all registered wakeup sources
and doing things accordingly. For example, SoC PM driver might need to
do HW programming to prevent powering down specific IP which wakeup
source depending on. So add this API to help walk through all registered
wakeup source objects on that list and return them one by one.
Signed-off-by: Ran Wang <redacted>
---
Change in v6:
- Add wakeup_source_get_star() and wakeup_source_get_stop() to aligned
with wakeup_sources_stats_seq_start/nex/stop.
Change in v5:
- Update commit message, add decription of walk through all wakeup
source objects.
- Add SCU protection in function wakeup_source_get_next().
- Rename wakeup_source member 'attached_dev' to 'dev' and move it up
(before wakeirq).
Change in v4:
- None.
Change in v3:
- Adjust indentation of *attached_dev;.
Change in v2:
- None.
drivers/base/power/wakeup.c | 39 +++++++++++++++++++++++++++++++++++++++
include/linux/pm_wakeup.h | 5 +++++
2 files changed, 44 insertions(+)
The NXP's QorIQ Processors based on ARM Core have RCPM module
(Run Control and Power Management), which performs system level
tasks associated with power management such as wakeup source control.
This driver depends on PM wakeup source framework which help to
collect wake information.
Signed-off-by: Ran Wang <redacted>
---
Change in v6:
- Adjust related API usage to meet wakeup.c's update in patch 1/3.
Change in v5:
- Fix v4 regression of the return value of wakeup_source_get_next()
didn't pass to ws in while loop.
- Rename wakeup_source member 'attached_dev' to 'dev'.
- Rename property 'fsl,#rcpm-wakeup-cells' to '#fsl,rcpm-wakeup-cells'.
please see https://lore.kernel.org/patchwork/patch/1101022/
Change in v4:
- Remove extra ',' in author line of rcpm.c
- Update usage of wakeup_source_get_next() to be less confusing to the
reader, code logic remain the same.
Change in v3:
- Some whitespace ajdustment.
Change in v2:
- Rebase Kconfig and Makefile update to latest mainline.
drivers/soc/fsl/Kconfig | 8 +++
drivers/soc/fsl/Makefile | 2 +
drivers/soc/fsl/rcpm.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 138 insertions(+)
create mode 100644 drivers/soc/fsl/rcpm.c
@@ -0,0 +1,128 @@+// SPDX-License-Identifier: GPL-2.0+//+// rcpm.c - Freescale QorIQ RCPM driver+//+// Copyright 2019 NXP+//+// Author: Ran Wang <ran.wang_1@nxp.com>++#include<linux/init.h>+#include<linux/module.h>+#include<linux/platform_device.h>+#include<linux/of_address.h>+#include<linux/slab.h>+#include<linux/suspend.h>+#include<linux/kernel.h>++#define RCPM_WAKEUP_CELL_MAX_SIZE 7++structrcpm{+unsignedintwakeup_cells;+void__iomem*ippdexpcr_base;+boollittle_endian;+};++staticintrcpm_pm_prepare(structdevice*dev)+{+structdevice_node*np=dev->of_node;+structwakeup_source*ws;+structrcpm*rcpm;+u32value[RCPM_WAKEUP_CELL_MAX_SIZE+1],tmp;+inti,ret,idx;++rcpm=dev_get_drvdata(dev);+if(!rcpm)+return-EINVAL;++/* Begin with first registered wakeup source */+ws=wakeup_source_get_start(&idx);+do{+/* skip object which is not attached to device */+if(!ws->dev)+continue;++ret=device_property_read_u32_array(ws->dev,+"fsl,rcpm-wakeup",value,rcpm->wakeup_cells+1);++/* Wakeup source should refer to current rcpm device */+if(ret||(np->phandle!=value[0])){+dev_info(dev,"%s doesn't refer to this rcpm\n",+ws->name);+continue;+}++for(i=0;i<rcpm->wakeup_cells;i++){+/* We can only OR related bits */+if(value[i+1]){+if(rcpm->little_endian){+tmp=ioread32(rcpm->ippdexpcr_base+i*4);+tmp|=value[i+1];+iowrite32(tmp,rcpm->ippdexpcr_base+i*4);+}else{+tmp=ioread32be(rcpm->ippdexpcr_base+i*4);+tmp|=value[i+1];+iowrite32be(tmp,rcpm->ippdexpcr_base+i*4);+}+}+}+}while(ws=wakeup_source_get_next(ws));++wakeup_source_get_stop(idx);++return0;+}++staticconststructdev_pm_opsrcpm_pm_ops={+.prepare=rcpm_pm_prepare,+};++staticintrcpm_probe(structplatform_device*pdev)+{+structdevice*dev=&pdev->dev;+structresource*r;+structrcpm*rcpm;+intret;++rcpm=devm_kzalloc(dev,sizeof(*rcpm),GFP_KERNEL);+if(!rcpm)+return-ENOMEM;++r=platform_get_resource(pdev,IORESOURCE_MEM,0);+if(!r)+return-ENODEV;++rcpm->ippdexpcr_base=devm_ioremap_resource(&pdev->dev,r);+if(IS_ERR(rcpm->ippdexpcr_base)){+ret=PTR_ERR(rcpm->ippdexpcr_base);+returnret;+}++rcpm->little_endian=device_property_read_bool(+&pdev->dev,"little-endian");++ret=device_property_read_u32(&pdev->dev,+"#fsl,rcpm-wakeup-cells",&rcpm->wakeup_cells);+if(ret)+returnret;++dev_set_drvdata(&pdev->dev,rcpm);++return0;+}++staticconststructof_device_idrcpm_of_match[]={+{.compatible="fsl,qoriq-rcpm-2.1+",},+{}+};+MODULE_DEVICE_TABLE(of,rcpm_of_match);++staticstructplatform_driverrcpm_driver={+.driver={+.name="rcpm",+.of_match_table=rcpm_of_match,+.pm=&rcpm_pm_ops,+},+.probe=rcpm_probe,+};++module_platform_driver(rcpm_driver);
By default, QorIQ SoC's RCPM register block is Big Endian. But
there are some exceptions, such as LS1088A and LS2088A, are
Little Endian. So add this optional property to help identify
them.
Actually LS2021A and other Layerscapes won't totally follow Chassis
2.1, so separate them from powerpc SoC.
Signed-off-by: Ran Wang <redacted>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Change in v6:
- None.
Change in v5:
- Add 'Reviewed-by: Rob Herring [off-list ref]' to commit message.
- Rename property 'fsl,#rcpm-wakeup-cells' to '#fsl,rcpm-wakeup-cells'.
please see https://lore.kernel.org/patchwork/patch/1101022/
Change in v4:
- Adjust indectation of 'ls1021a, ls1012a, ls1043a, ls1046a'.
Change in v3:
- None.
Change in v2:
- None.
Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
@@ -5,7 +5,7 @@ and power management. Required properites: - reg : Offset and length of the register set of the RCPM block.- - fsl,#rcpm-wakeup-cells : The number of IPPDEXPCR register cells in the+ - #fsl,rcpm-wakeup-cells : The number of IPPDEXPCR register cells in the fsl,rcpm-wakeup property. - compatible : Must contain a chip-specific RCPM block compatible string and (if applicable) may contain a chassis-version RCPM compatible
@@ -20,6 +20,7 @@ Required properites: * "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm * "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm * "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm+ * "fsl,qoriq-rcpm-2.1+": for chassis 2.1+ rcpm All references to "1.0" and "2.0" refer to the QorIQ chassis version to which the chip complies.
@@ -27,14 +28,19 @@ Chassis Version Example Chips --------------- ------------------------------- 1.0 p4080, p5020, p5040, p2041, p3041 2.0 t4240, b4860, b4420-2.1 t1040, ls1021+2.1 t1040,+2.1+ ls1021a, ls1012a, ls1043a, ls1046a++Optional properties:+ - little-endian : RCPM register block is Little Endian. Without it RCPM+ will be Big Endian (default case). Example: The RCPM node for T4240: rcpm: global-utilities@e2000 { compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0"; reg = <0xe2000 0x1000>;- fsl,#rcpm-wakeup-cells = <2>;+ #fsl,rcpm-wakeup-cells = <2>; }; * Freescale RCPM Wakeup Source Device Tree Bindings
@@ -44,7 +50,7 @@ can be used as a wakeup source. - fsl,rcpm-wakeup: Consists of a phandle to the rcpm node and the IPPDEXPCR register cells. The number of IPPDEXPCR register cells is defined in- "fsl,#rcpm-wakeup-cells" in the rcpm node. The first register cell is+ "#fsl,rcpm-wakeup-cells" in the rcpm node. The first register cell is the bit mask that should be set in IPPDEXPCR0, and the second register cell is for IPPDEXPCR1, and so on.
Hi Pavel,
On Wednesday, August 21, 2019 11:16, Ran Wang wrote:
quoted hunk
The NXP's QorIQ Processors based on ARM Core have RCPM module (Run
Control and Power Management), which performs system level tasks associated
with power management such as wakeup source control.
This driver depends on PM wakeup source framework which help to collect wake
information.
Signed-off-by: Ran Wang <redacted>
---
Change in v6:
- Adjust related API usage to meet wakeup.c's update in patch 1/3.
Change in v5:
- Fix v4 regression of the return value of wakeup_source_get_next()
didn't pass to ws in while loop.
- Rename wakeup_source member 'attached_dev' to 'dev'.
- Rename property 'fsl,#rcpm-wakeup-cells' to '#fsl,rcpm-wakeup-cells'.
please see
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kern
el.org%2Fpatchwork%2Fpatch%2F1101022%2F&data=02%7C01%7Cran.wa
ng_1%40nxp.com%7C27cff523c0a54ce89afe08d725e5987b%7C686ea1d3bc2b4
c6fa92cd99c5c301635%7C0%7C0%7C637019540358555022&sdata=4YYGD
lwvB%2B4Y1436c1bOUzFyjYEqTU5HbiUFv5%2FCxi0%3D&reserved=0
Change in v4:
- Remove extra ',' in author line of rcpm.c
- Update usage of wakeup_source_get_next() to be less confusing to
the reader, code logic remain the same.
Change in v3:
- Some whitespace ajdustment.
Change in v2:
- Rebase Kconfig and Makefile update to latest mainline.
drivers/soc/fsl/Kconfig | 8 +++
drivers/soc/fsl/Makefile | 2 +
drivers/soc/fsl/rcpm.c | 128
+++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 138 insertions(+)
create mode 100644 drivers/soc/fsl/rcpm.c
diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig index
diff --git a/drivers/soc/fsl/rcpm.c b/drivers/soc/fsl/rcpm.c new file mode
100644 index 0000000..82c0ad5
--- /dev/null+++ b/drivers/soc/fsl/rcpm.c
@@ -0,0 +1,128 @@+// SPDX-License-Identifier: GPL-2.0+//+// rcpm.c - Freescale QorIQ RCPM driver // // Copyright 2019 NXP // //+Author:RanWang<ran.wang_1@nxp.com>++#include<linux/init.h>+#include<linux/module.h>+#include<linux/platform_device.h>+#include<linux/of_address.h>+#include<linux/slab.h>+#include<linux/suspend.h>+#include<linux/kernel.h>++#define RCPM_WAKEUP_CELL_MAX_SIZE 7++structrcpm{+unsignedintwakeup_cells;+void__iomem*ippdexpcr_base;+boollittle_endian;+};++staticintrcpm_pm_prepare(structdevice*dev){+structdevice_node*np=dev->of_node;+structwakeup_source*ws;+structrcpm*rcpm;+u32value[RCPM_WAKEUP_CELL_MAX_SIZE+1],tmp;+inti,ret,idx;++rcpm=dev_get_drvdata(dev);+if(!rcpm)+return-EINVAL;++/* Begin with first registered wakeup source */+ws=wakeup_source_get_start(&idx);
Since I have mad some change in this version, could you please take a look on this.
If it's OK to you, I would re-add 'Acked-by: Pavel Machek [off-list ref] '
+ do {
+ /* skip object which is not attached to device */
+ if (!ws->dev)
+ continue;
+
+ ret = device_property_read_u32_array(ws->dev,
+ "fsl,rcpm-wakeup", value, rcpm->wakeup_cells
+ 1);
+
+ /* Wakeup source should refer to current rcpm device */
+ if (ret || (np->phandle != value[0])) {
+ dev_info(dev, "%s doesn't refer to this rcpm\n",
+ ws->name);
+ continue;
+ }
+
+ for (i = 0; i < rcpm->wakeup_cells; i++) {
+ /* We can only OR related bits */
+ if (value[i + 1]) {
+ if (rcpm->little_endian) {
+ tmp = ioread32(rcpm->ippdexpcr_base
+ i * 4);
+ tmp |= value[i + 1];
+ iowrite32(tmp, rcpm->ippdexpcr_base
+ i * 4);
+ } else {
+ tmp = ioread32be(rcpm-
From: Pavel Machek <hidden> Date: 2019-09-03 14:12:54
Hi!
quoted
+ /* Begin with first registered wakeup source */
+ ws = wakeup_source_get_start(&idx);
Since I have mad some change in this version, could you please take a look on this.
If it's OK to you, I would re-add 'Acked-by: Pavel Machek [off-list ref] '
Hi Rafael,
On Wednesday, August 21, 2019 11:16, Ran Wang wrote:
Some user might want to go through all registered wakeup sources and doing
things accordingly. For example, SoC PM driver might need to do HW
programming to prevent powering down specific IP which wakeup source
depending on. So add this API to help walk through all registered wakeup source
objects on that list and return them one by one.
Signed-off-by: Ran Wang <redacted>
---
Change in v6:
- Add wakeup_source_get_star() and wakeup_source_get_stop() to
aligned
with wakeup_sources_stats_seq_start/nex/stop.
How about this version, could you please give any comment? Thanks.
Regards,
Ran
<snip>