When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building GCC but
clang is multitargeted and does not need these flags. The ABI is
properly set based on the target triple, which is derived from
CROSS_COMPILE.
https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/clang/lib/Driver/ToolChains/Clang.cpp#L1782-L1804
-mcall-aixdesc is not an implemented flag in clang so it can be
safely excluded as well, see commit 238abecde8ad ("powerpc: Don't
use gcc specific options on clang").
pseries_defconfig successfully builds after this patch and
powernv_defconfig and ppc44x_defconfig don't regress.
Link: https://github.com/ClangBuiltLinux/linux/issues/240
Signed-off-by: Nathan Chancellor <redacted>
---
arch/powerpc/Makefile | 4 ++++
1 file changed, 4 insertions(+)
From: Daniel Axtens <hidden> Date: 2019-08-19 07:25:54
Hi Nathan,
When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building GCC but
clang is multitargeted and does not need these flags. The ABI is
properly set based on the target triple, which is derived from
CROSS_COMPILE.
https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/clang/lib/Driver/ToolChains/Clang.cpp#L1782-L1804
-mcall-aixdesc is not an implemented flag in clang so it can be
safely excluded as well, see commit 238abecde8ad ("powerpc: Don't
use gcc specific options on clang").
This all looks good to me, thanks for picking it up, and sorry I hadn't
got around to it!
The makefile is a bit messy and there are a few ways it could probably
be reorganised to reduce ifdefs. But I don't think this is the right
place to do that. With that in mind,
Reviewed-by: Daniel Axtens <redacted>
Regards,
Daniel
quoted hunk
pseries_defconfig successfully builds after this patch and
powernv_defconfig and ppc44x_defconfig don't regress.
Link: https://github.com/ClangBuiltLinux/linux/issues/240
Signed-off-by: Nathan Chancellor <redacted>
---
arch/powerpc/Makefile | 4 ++++
1 file changed, 4 insertions(+)
On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor wrote:
When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building GCC but
clang is multitargeted and does not need these flags. The ABI is
properly set based on the target triple, which is derived from
CROSS_COMPILE.
You mean that LLVM does not *allow* you to select a different ABI, or
different ABI options, you always have to use the default. (Everything
else you say is true for GCC as well).
(-mabi= does not set a "target ABI", fwiw, it is more subtle; please see
the documentation. Unless LLVM is incompatible in that respect as well?)
Segher
On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote:
On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor wrote:
quoted
When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building GCC but
clang is multitargeted and does not need these flags. The ABI is
properly set based on the target triple, which is derived from
CROSS_COMPILE.
You mean that LLVM does not *allow* you to select a different ABI, or
different ABI options, you always have to use the default. (Everything
else you say is true for GCC as well).
(-mabi= does not set a "target ABI", fwiw, it is more subtle; please see
the documentation. Unless LLVM is incompatible in that respect as well?)
Are you referring to the error message? I suppose I could file an LLVM
bug report on that but that message applies to all of the '-mabi='
options, which may refer to a target ABI.
Cheers,
Nathan
On Mon, Aug 19, 2019 at 08:15:38PM -0700, Nathan Chancellor wrote:
On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote:
quoted
On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor wrote:
quoted
When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building GCC but
clang is multitargeted and does not need these flags. The ABI is
properly set based on the target triple, which is derived from
CROSS_COMPILE.
You mean that LLVM does not *allow* you to select a different ABI, or
different ABI options, you always have to use the default. (Everything
else you say is true for GCC as well).
I need to improve the wording of the commit message as it is really that
clang does not allow a different ABI to be selected for 32-bit PowerPC,
as the setABI function is not overridden and it defaults to false.
GCC appears to just silently ignores this flag (I think it is the
SUBSUBTARGET_OVERRIDE_OPTIONS macro in gcc/config/rs6000/linux64.h).
What flag? -mabi=elfv[12]?
(Only irrelevant things are ever ignored; otherwise, please do a bug
report).
It can be changed for 64-bit PowerPC it seems but it doesn't need to be
with clang because everything is set properly internally (I'll find a
better way to clearly word that as I am sure I'm not quite getting that
subtlety right).
You can have elfv2 on BE, and e.g. the sysv ABI on LE. Neither of those
is tested a lot.
quoted
(-mabi= does not set a "target ABI", fwiw, it is more subtle; please see
the documentation. Unless LLVM is incompatible in that respect as well?)
Are you referring to the error message?
Yup.
I suppose I could file an LLVM
bug report on that but that message applies to all of the '-mabi='
options, which may refer to a target ABI.
That depends on what you call "an ABI", I guess. You can call any ABI
variant a separate ABI: you'll have to rebuild all of userland. You can
also says ELFv1 and ELFv2 are pretty much the same thing, which is true
as well. The way -mabi= is defined is the latter:
'-mabi=ABI-TYPE'
Extend the current ABI with a particular extension, or remove such
extension. Valid values are 'altivec', 'no-altivec',
'ibmlongdouble', 'ieeelongdouble', 'elfv1', 'elfv2'.
Segher
On Tue, Aug 20, 2019 at 07:40:33AM -0500, Segher Boessenkool wrote:
On Mon, Aug 19, 2019 at 08:15:38PM -0700, Nathan Chancellor wrote:
quoted
On Mon, Aug 19, 2019 at 04:19:31AM -0500, Segher Boessenkool wrote:
quoted
On Sun, Aug 18, 2019 at 12:13:21PM -0700, Nathan Chancellor wrote:
quoted
When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building GCC but
clang is multitargeted and does not need these flags. The ABI is
properly set based on the target triple, which is derived from
CROSS_COMPILE.
You mean that LLVM does not *allow* you to select a different ABI, or
different ABI options, you always have to use the default. (Everything
else you say is true for GCC as well).
I need to improve the wording of the commit message as it is really that
clang does not allow a different ABI to be selected for 32-bit PowerPC,
as the setABI function is not overridden and it defaults to false.
quoted
GCC appears to just silently ignores this flag (I think it is the
SUBSUBTARGET_OVERRIDE_OPTIONS macro in gcc/config/rs6000/linux64.h).
What flag? -mabi=elfv[12]?
Yes.
(Only irrelevant things are ever ignored; otherwise, please do a bug
report).
I believe that is the case here but looking at the GCC source gives me a
headache.
quoted
It can be changed for 64-bit PowerPC it seems but it doesn't need to be
with clang because everything is set properly internally (I'll find a
better way to clearly word that as I am sure I'm not quite getting that
subtlety right).
You can have elfv2 on BE, and e.g. the sysv ABI on LE. Neither of those
is tested a lot.
quoted
quoted
(-mabi= does not set a "target ABI", fwiw, it is more subtle; please see
the documentation. Unless LLVM is incompatible in that respect as well?)
Are you referring to the error message?
Yup.
quoted
I suppose I could file an LLVM
bug report on that but that message applies to all of the '-mabi='
options, which may refer to a target ABI.
That depends on what you call "an ABI", I guess. You can call any ABI
variant a separate ABI: you'll have to rebuild all of userland. You can
also says ELFv1 and ELFv2 are pretty much the same thing, which is true
as well. The way -mabi= is defined is the latter:
'-mabi=ABI-TYPE'
Extend the current ABI with a particular extension, or remove such
extension. Valid values are 'altivec', 'no-altivec',
'ibmlongdouble', 'ieeelongdouble', 'elfv1', 'elfv2'.
Segher
The GCC documentation also has this description for '-mabi=elfv1' and
'-mabi=elfv2':
-mabi=elfv1:
Change the current ABI to use the ELFv1 ABI. This is the default ABI for
big-endian PowerPC 64-bit Linux. Overriding the default ABI requires
special system support and is likely to fail in spectacular ways.
-mabi=elfv2:
Change the current ABI to use the ELFv2 ABI. This is the default ABI for
little-endian PowerPC 64-bit Linux. Overriding the default ABI requires
special system support and is likely to fail in spectacular ways.
https://gcc.gnu.org/onlinedocs/gcc/RS_002f6000-and-PowerPC-Options.html#index-mabi_003delfv1
Thinking about this a little bit more, I think this patch is correct in
the case that clang is cross compiling because the target triple will
always be specified (so the default ABI doesn't need to be changed).
However, I am not sure how native compiling would be affected by this
change; in theory, if someone was on a little endian system and wanted
to build a big endian kernel, they would probably need -mabi=elfv1
like GCC would but I don't have any real way to test this nor am I sure
that anyone actually natively compiles PowerPC kernels with clang. It's
probably not worrying about at this point so I'll just move forward with
a v2 rewording the commit message.
Cheers,
Nathan
When building pseries_defconfig, building vdso32 errors out:
error: unknown target ABI 'elfv1'
This happens because -m32 in clang changes the target to 32-bit,
which does not allow the ABI to be changed, as the setABI virtual
function is not overridden:
https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/clang/include/clang/Basic/TargetInfo.h#L1073-L1078https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/clang/lib/Basic/Targets/PPC.h#L327-L365
Commit 4dc831aa8813 ("powerpc: Fix compiling a BE kernel with a
powerpc64le toolchain") added these flags to fix building big endian
kernels with a little endian GCC.
Clang doesn't need -mabi because the target triple controls the default
value. -mlittle-endian and -mbig-endian manipulate the triple into
either powerpc64-* or powerpc64le-*, which properly sets the default
ABI:
https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/clang/lib/Driver/Driver.cpp#L450-L463https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/llvm/lib/Support/Triple.cpp#L1432-L1516https://github.com/llvm/llvm-project/blob/llvmorg-9.0.0-rc2/clang/lib/Basic/Targets/PPC.h#L377-L383
Adding a debug print out in the PPC64TargetInfo constructor after line
383 above shows this:
$ echo | ./clang -E --target=powerpc64-linux -mbig-endian -o /dev/null -
Default ABI: elfv1
$ echo | ./clang -E --target=powerpc64-linux -mlittle-endian -o /dev/null -
Default ABI: elfv2
$ echo | ./clang -E --target=powerpc64le-linux -mbig-endian -o /dev/null -
Default ABI: elfv1
$ echo | ./clang -E --target=powerpc64le-linux -mlittle-endian -o /dev/null -
Default ABI: elfv2
Don't specify -mabi when building with clang to avoid the build error
with -m32 and not change any code generation.
-mcall-aixdesc is not an implemented flag in clang so it can be
safely excluded as well, see commit 238abecde8ad ("powerpc: Don't
use gcc specific options on clang").
pseries_defconfig successfully builds after this patch and
powernv_defconfig and ppc44x_defconfig don't regress.
Link: https://github.com/ClangBuiltLinux/linux/issues/240
Reviewed-by: Daniel Axtens <redacted>
Signed-off-by: Nathan Chancellor <redacted>
---
v1 -> v2:
* Improve commit message wording and explanation.
* Add Daniel's reviewed-by.
arch/powerpc/Makefile | 4 ++++
1 file changed, 4 insertions(+)