[5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

5 messages, 2 authors, 2019-08-19 · open the first message on its own page

[5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

From: Abdul Haleem <hidden>
Date: 2019-08-14 16:52:25

Greeting's

Today's linux-next kernel (5.3.0-rc4-next-20190813)  booted with warning on my powerpc power 8 lpar

The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...)

boot logs:

scsi host1: qla2xxx
qla2xxx [0106:a0:00.0]-00fb:1: QLogic QLE2562 - PCIe 2-port 8Gb FC Adapter.
qla2xxx [0106:a0:00.0]-00fc:1: ISP2532: PCIe (5.0GT/s x8) @ 0106:a0:00.0 hdma- host#=1 fw=8.03.00 (90d5).
qla2xxx [0106:a0:00.1]-001a: : MSI-X vector count: 32.
qla2xxx [0106:a0:00.1]-001d: : Found an ISP2532 irq 506 iobase 0x(____ptrval____).
qla2xxx [0106:a0:00.1]-00c6:2: MSI-X: Failed to enable support with 32 vectors, using 16 vectors.
qla2xxx [0106:a0:00.0]-500a:1: LOOP UP detected (8 Gbps).
scsi host2: qla2xxx
qla2xxx [0106:a0:00.1]-00fb:2: QLogic QLE2562 - PCIe 2-port 8Gb FC Adapter.
qla2xxx [0106:a0:00.1]-00fc:2: ISP2532: PCIe (5.0GT/s x8) @ 0106:a0:00.1 hdma- host#=2 fw=8.03.00 (90d5).
qla2xxx [0106:a0:00.1]-500a:2: LOOP UP detected (8 Gbps).
scsi: waiting for bus probes to complete ...
scsi 1:0:0:0: Direct-Access     IBM      2145             0000 PQ: 0 ANSI: 6
scsi 1:0:0:0: alua: supports implicit TPGS
scsi 1:0:0:0: alua: device naa.60050764008100dac000000000000018 port group 1 rel port 881 
scsi 1:0:0:1: Direct-Access     IBM      2145             0000 PQ: 0 ANSI: 6
scsi 1:0:0:1: alua: supports implicit TPGS
scsi 1:0:0:1: alua: device naa.60050764008100dac000000000000019 port group 0 rel port 881 
WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784
qla2x00_status_entry.isra.7+0x484/0x17b0 [qla2xxx]
Modules linked in: sd_mod(E) ibmvscsi(E+) qla2xxx(E)
scsi_transport_srp(E) ibmveth(E) nvme_fc(E) nvme_fabrics(E) nvme_core(E)
scsi_transport_fc(E) tg3(E) ptp(E) pps_core(E)
CPU: 10 PID: 425 Comm: kworker/10:1 Tainted: G            E     5.3.0-rc4-next-20190813-autotest-autotest #1
Workqueue: qla2xxx_wq qla25xx_free_rsp_que [qla2xxx]
NIP:  c008000000b7e2ac LR: c008000000b7f2c8 CTR: c000000000097f00
REGS: c0000000ff3376d0 TRAP: 0700   Tainted: G            E      (5.3.0-rc4-next-20190813-autotest-autotest)
MSR:  800000000282b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE>  CR: 88002888  XER: 20000000
CFAR: c008000000b7f2cc IRQMASK: 1 
GPR00: c008000000b7f2ac c0000000ff337960 c008000000c28000 0000000008020000 
GPR04: c00000028b326848 000000000000302b c000000280169800 000000000000001c 
GPR08: 0000000000000000 c00000027c18c3a8 c00000027c18c210 c008000000be3850 
GPR12: c000000000097f00 c00000000ec5a680 0000000000000000 0000000000000200 
GPR16: 0000000000000002 0000000000000000 0000000000000028 0000000000000024 
GPR20: c0000000fe91dc00 0000000000001000 0000000000000000 c000000283d95560 
GPR24: 0000000000000000 c00000027c18c210 c00000028b326848 c00000028b326848 
GPR28: 000000000000001c c00000027c18c3a8 0000000000000002 c00000027c18c210 
NIP [c008000000b7e2ac] qla2x00_status_entry.isra.7+0x484/0x17b0 [qla2xxx]
LR [c008000000b7f2c8] qla2x00_status_entry.isra.7+0x14a0/0x17b0 [qla2xxx]
Call Trace:
[c0000000ff337960] [c008000000b7f2ac] qla2x00_status_entry.isra.7+0x1484/0x17b0 [qla2xxx] (unreliable)
[c0000000ff337af0] [c008000000b80970] qla24xx_process_response_queue+0x7d8/0xbd0 [qla2xxx]
[c0000000ff337c30] [c008000000baafa8] qla25xx_free_rsp_que+0x1a0/0x220 [qla2xxx]
[c0000000ff337c70] [c000000000139bbc] process_one_work+0x25c/0x520
[c0000000ff337d10] [c000000000139f0c] worker_thread+0x8c/0x5e0
[c0000000ff337db0] [c000000000141ca4] kthread+0x154/0x1a0
[c0000000ff337e20] [c00000000000b760] ret_from_kernel_thread+0x5c/0x7c
Instruction dump:
f8010078 8814002a f8010070 e80b0088 f8010068 816b0080 f9610060 480126e9 
60000000 e9370000 2fa90000 419e0a70 <0fe00000> 4bfffdf8 60000000 60000000 
---[ end trace c1bdb0f821236f7a ]---
sd 1:0:0:1: Power-on or device reset occurred 

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre

Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

From: Abdul Haleem <hidden>
Date: 2019-08-14 17:19:09

On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote:

On 8/14/19 9:52 AM, Abdul Haleem wrote:

quoted

Greeting's

Today's linux-next kernel (5.3.0-rc4-next-20190813)  booted with warning on my powerpc power 8 lpar

The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...)

boot logs:

WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784

Hi Abdul,

Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx
driver? If that warning is commented out, does the qla2xxx driver work as expected?

boot warning did not show up when the commit is reverted.

should I comment out only the WARN_ON_ONCE() which is causing the issue,
and not the other one ?

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre

Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

From: Bart Van Assche <bvanassche@acm.org>
Date: 2019-08-14 17:26:02

On 8/14/19 9:52 AM, Abdul Haleem wrote:

Greeting's

Today's linux-next kernel (5.3.0-rc4-next-20190813)  booted with warning on my powerpc power 8 lpar

The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...)

boot logs:

WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784

Hi Abdul,

Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx
driver? If that warning is commented out, does the qla2xxx driver work as expected?

Thanks,

Bart.

Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

From: Bart Van Assche <bvanassche@acm.org>
Date: 2019-08-15 03:42:22

On 8/14/19 10:18 AM, Abdul Haleem wrote:

On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote:

quoted

On 8/14/19 9:52 AM, Abdul Haleem wrote:

quoted

Greeting's

Today's linux-next kernel (5.3.0-rc4-next-20190813)  booted with warning on my powerpc power 8 lpar

The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...)

boot logs:

WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784

Hi Abdul,

Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx
driver? If that warning is commented out, does the qla2xxx driver work as expected?

boot warning did not show up when the commit is reverted.

should I comment out only the WARN_ON_ONCE() which is causing the issue,
and not the other one ?

Yes please. Commit 88263208 introduced five kernel warnings but I think 
only one of these should be removed again, e.g. as follows:

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index cd39ac18c5fd..d81b5ecce24b 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c

@@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct

rsp_que *rsp, void *pkt)

  	if (rsp->status_srb == NULL)
  		sp->done(sp, res);
-	else
-		WARN_ON_ONCE(true);
  }

  /**

Re: [5.3.0-rc4-next][bisected 882632][qla2xxx] WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784 qla2x00_status_entry.isra

From: Abdul Haleem <hidden>
Date: 2019-08-19 10:27:14

On Wed, 2019-08-14 at 20:42 -0700, Bart Van Assche wrote:

quoted hunk

On 8/14/19 10:18 AM, Abdul Haleem wrote:

quoted

On Wed, 2019-08-14 at 10:05 -0700, Bart Van Assche wrote:

quoted

On 8/14/19 9:52 AM, Abdul Haleem wrote:

quoted

Greeting's

Today's linux-next kernel (5.3.0-rc4-next-20190813)  booted with warning on my powerpc power 8 lpar

The WARN_ON_ONCE() was introduced by commit 88263208 (scsi: qla2xxx: Complain if sp->done() is not...)

boot logs:

WARNING: CPU: 10 PID: 425 at drivers/scsi/qla2xxx/qla_isr.c:2784

Hi Abdul,

Thank you for having reported this. Is that the only warning reported on your setup by the qla2xxx
driver? If that warning is commented out, does the qla2xxx driver work as expected?

boot warning did not show up when the commit is reverted.

should I comment out only the WARN_ON_ONCE() which is causing the issue,
and not the other one ?

Yes please. Commit 88263208 introduced five kernel warnings but I think 
only one of these should be removed again, e.g. as follows:

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index cd39ac18c5fd..d81b5ecce24b 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c

@@ -2780,8 +2780,6 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct

rsp_que *rsp, void *pkt)

  	if (rsp->status_srb == NULL)
  		sp->done(sp, res);
-	else
-		WARN_ON_ONCE(true);
  }

  /**

 
Applying above patch on system boots fine.

i.e no warnings pop up when keeping all WARN_ON_ONCE() except above one.

Reported-and-Tested-by: Abdul Haleem <redacted>

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help