From: Alastair D'Silva <redacted>
When calling flush_icache_range with a size >4GB, we were masking
off the upper 32 bits, so we would incorrectly flush a range smaller
than intended.
This patch replaces the 32 bit shifts with 64 bit ones, so that
the full size is accounted for.
Heads-up for backporters: the old version of flush_dcache_range is
subject to a similar bug (this has since been replaced with a C
implementation).
Signed-off-by: Alastair D'Silva <redacted>
---
arch/powerpc/kernel/misc_64.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Alastair D'Silva <redacted>
When calling flush_icache_range with a size >4GB, we were masking
off the upper 32 bits, so we would incorrectly flush a range smaller
than intended.
This patch replaces the 32 bit shifts with 64 bit ones, so that
the full size is accounted for.
Heads-up for backporters: the old version of flush_dcache_range is
subject to a similar bug (this has since been replaced with a C
implementation).
Can you submit a patch to stable, explaining this ?
Signed-off-by: Alastair D'Silva <redacted>
Reviewed-by: Christophe Leroy <redacted>
Should add:
Cc: stable@vger.kernel.org
Christophe
On Fri, 2019-08-09 at 10:59 +0200, Christophe Leroy wrote:
Le 09/08/2019 à 02:45, Alastair D'Silva a écrit :
quoted
From: Alastair D'Silva <redacted>
When calling flush_icache_range with a size >4GB, we were masking
off the upper 32 bits, so we would incorrectly flush a range
smaller
than intended.
This patch replaces the 32 bit shifts with 64 bit ones, so that
the full size is accounted for.
Heads-up for backporters: the old version of flush_dcache_range is
subject to a similar bug (this has since been replaced with a C
implementation).
Can you submit a patch to stable, explaining this ?
This patch was sent to stable too - or did you mean send another patch
for the stable asm version of flush_dcache_range?
--
Alastair D'Silva
Open Source Developer
Linux Technology Centre, IBM Australia
mob: 0423 762 819
On Fri, 2019-08-09 at 10:59 +0200, Christophe Leroy wrote:
quoted
Le 09/08/2019 à 02:45, Alastair D'Silva a écrit :
quoted
From: Alastair D'Silva <redacted>
When calling flush_icache_range with a size >4GB, we were masking
off the upper 32 bits, so we would incorrectly flush a range
smaller
than intended.
This patch replaces the 32 bit shifts with 64 bit ones, so that
the full size is accounted for.
Heads-up for backporters: the old version of flush_dcache_range is
subject to a similar bug (this has since been replaced with a C
implementation).
Can you submit a patch to stable, explaining this ?
This patch was sent to stable too - or did you mean send another patch
for the stable asm version of flush_dcache_range?
Yes I meant a patch for your 'heads-up', in extenso a patch for fixing
flush_dcache_range().
And for this patch, you put stable is copy of the mail, but for it to be
taken into account it needs to also explicitely include a Cc:
stable@vger.kernel.org in the commit message. I guess Michael will add
it for this time.
Christophe