# Re: \[PATCH\] powerpc/xmon: Fix disabling tracing while in xmon

- From: Michael Ellerman \<hidden\>
- Date: 2019-07-03 14:50:24 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/07/9510811
- Thread: https://ratatoskr.run/linuxppc-dev/2019/06/9510645/t.md

```text
On Thu, 2019-06-27 at 09:59:40 UTC, "Naveen N. Rao" wrote:
> Commit ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering
> xmon") added code to disable recording trace entries while in xmon. The
> commit introduced a variable 'tracing_enabled' to record if tracing was
> enabled on xmon entry, and used this to conditionally enable tracing
> during exit from xmon.
> 
> However, we are not checking the value of 'fromipi' variable in
> xmon_core() when setting 'tracing_enabled'. Due to this, when secondary
> cpus enter xmon, they will see tracing as being disabled already and
> tracing won't be re-enabled on exit. Fix the same.
> 
> Fixes: ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering xmon")
> Signed-off-by: Naveen N. Rao <redacted>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/aaf06665f7ea3ee9f9754e16c1a507a89f1de5b1

cheers
```