# Re: \[PATCH v3\] tpm: tpm\_ibm\_vtpm: Fix unallocated banks

- From: Jarkko Sakkinen \<hidden\>
- Date: 2019-07-11 20:28:35 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/07/5653353
- Thread: https://ratatoskr.run/linux-integrity/2019/07/5653210/t.md

```text
On Thu, Jul 11, 2019 at 12:13:35PM -0400, Nayna Jain wrote:
> The nr_allocated_banks and allocated banks are initialized as part of
> tpm_chip_register. Currently, this is done as part of auto startup
> function. However, some drivers, like the ibm vtpm driver, do not run
> auto startup during initialization. This results in uninitialized memory
> issue and causes a kernel panic during boot.
> 
> This patch moves the pcr allocation outside the auto startup function
> into tpm_chip_register. This ensures that allocated banks are initialized
> in any case.
> 
> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
> PCR read")
> Reported-by: Michal Suchanek <redacted>
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> Tested-by: Sachin Sant <redacted>
> Tested-by: Michal Suchánek <redacted>

Reviewed-by: Jarkko Sakkinen <redacted>

/Jarkko
```
