# Re: \[PATCH\] powerpc/hw\_breakpoint: move instruction stepping out of hw\_breakpoint\_handler()

- From: Christophe Leroy \<hidden\>
- Date: 2019-07-06 08:26:56 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/07/5649083
- Thread: https://ratatoskr.run/linuxppc-dev/2019/06/5643673/t.md

```text


Le 03/07/2019 à 08:20, Ravi Bangoria a écrit :
>
>
> On 6/28/19 9:25 PM, Christophe Leroy wrote:
>> On 8xx, breakpoints stop after executing the instruction, so
>> stepping/emulation is not needed. Move it into a sub-function and
>> remove the #ifdefs.
>>
>> Signed-off-by: Christophe Leroy <redacted>
>> ---
>
> Reviewed-by: Ravi Bangoria <redacted>
>
> Just one neat below...

Thanks for the review.

>
> [...]
>
>> -#ifndef CONFIG_PPC_8xx
>> -	/* Do not emulate user-space instructions, instead single-step them */
>> -	if (user_mode(regs)) {
>> -		current->thread.last_hit_ubp = bp;
>> -		regs->msr |= MSR_SE;
>> +	if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))
>
> May be split this line. It's 86 chars long and checkpatch.pl is warning
> about this:

Didn't you use arch/powerpc/tools/checkpatch.sh ?

powerpc accepts 90 chars per line.

Christophe

>
> WARNING: line over 80 characters
> #257: FILE: arch/powerpc/kernel/hw_breakpoint.c:282:
> +	if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))
>
```