# Re: \[PATCH\] powerpc/hw\_breakpoint: move instruction stepping out of hw\_breakpoint\_handler()

- From: Ravi Bangoria \<hidden\>
- Date: 2019-07-03 06:20:30 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/07/5646546
- Thread: https://ratatoskr.run/linuxppc-dev/2019/06/5643673/t.md

```text


On 6/28/19 9:25 PM, Christophe Leroy wrote:
> On 8xx, breakpoints stop after executing the instruction, so
> stepping/emulation is not needed. Move it into a sub-function and
> remove the #ifdefs.
> 
> Signed-off-by: Christophe Leroy <redacted>
> ---

Reviewed-by: Ravi Bangoria <redacted>

Just one neat below...

[...]

> -#ifndef CONFIG_PPC_8xx
> -	/* Do not emulate user-space instructions, instead single-step them */
> -	if (user_mode(regs)) {
> -		current->thread.last_hit_ubp = bp;
> -		regs->msr |= MSR_SE;
> +	if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))

May be split this line. It's 86 chars long and checkpatch.pl is warning
about this:

WARNING: line over 80 characters
#257: FILE: arch/powerpc/kernel/hw_breakpoint.c:282:
+	if (!IS_ENABLED(CONFIG_PPC_8xx) && !stepping_handler(regs, bp, info->address))

```