# Re: \[PATCH v3\] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi\_do\_work

- From: Tyrel Datwyler \<hidden\>
- Date: 2019-06-03 23:58:25 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/06/5616863
- Thread: https://ratatoskr.run/linux-scsi/2019/05/5614609/t.md

```text
On 06/03/2019 04:44 PM, Nathan Chancellor wrote:
> clang warns:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used
> uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
>         case IBMVSCSI_HOST_ACTION_NONE:
>              ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized use occurs
> here
>         if (rc) {
>             ^~
> 
> Initialize rc in the IBMVSCSI_HOST_ACTION_UNBLOCK case statement then
> shuffle IBMVSCSI_HOST_ACTION_NONE down to the default case statement and
> make it return early so that rc is never used uninitialized in this
> function.
> 
> Fixes: 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> Link: https://github.com/ClangBuiltLinux/linux/issues/502
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Suggested-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> Signed-off-by: Nathan Chancellor <redacted>

Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>

```