# \[PATCH\] dlpar: Fix a missing-check bug in dlpar\_parse\_cc\_property()

- From: Gen Zhang \<hidden\>
- Date: 2019-05-30 00:58:39 
- List: linuxppc-dev
- Page: https://ratatoskr.run/linuxppc-dev/2019/05/5611424
- Thread: https://ratatoskr.run/linuxppc-dev/2019/05/5611424/t.md

```text
In dlpar_parse_cc_property(), 'prop->name' is allocated by kstrdup().
kstrdup() may return NULL, so it should be checked and handle error.
And prop should be freed if 'prop->name' is NULL.

Signed-off-by: Gen Zhang <redacted>
Acked-by: Nathan Lynch <redacted>
---
diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
index 1795804..c852024 100644
--- a/arch/powerpc/platforms/pseries/dlpar.c
+++ b/arch/powerpc/platforms/pseries/dlpar.c
@@ -61,6 +61,10 @@ static struct property *dlpar_parse_cc_property(struct cc_workarea *ccwa)
 
 	name = (char *)ccwa + be32_to_cpu(ccwa->name_offset);
 	prop->name = kstrdup(name, GFP_KERNEL);
+	if (!prop->name) {
+		dlpar_free_cc_property(prop);
+		return NULL;
+	}
 
 	prop->length = be32_to_cpu(ccwa->prop_length);
 	value = (char *)ccwa + be32_to_cpu(ccwa->prop_offset);
---
```