# \[PATCH v3 10/10\] powerpc: tsi108: support of\_get\_mac\_address new ERR\_PTR error

- Subsystems: LINUX FOR POWERPC (32-BIT AND 64-BIT), THE REST
- Maintainers: Madhavan Srinivasan, Linus Torvalds
- Status: SUPERSEDED (Superseded by v4 posted 2019-05-03)
- Superseded by v4 (posted 2019-05-03).
- Revision v3 (2 revisions archived).
- List: linuxppc-dev
- 1 message, 1 author
- Page: https://ratatoskr.run/linuxppc-dev/2019/05/5587489/t

## \[PATCH v3 10/10\] powerpc: tsi108: support of\_get\_mac\_address new ERR\_PTR error

- From: Petr Štetiar \<hidden\>
- Date: 2019-05-03 07:57:04 
- Message: https://ratatoskr.run/linuxppc-dev/2019/05/5587489.md

```text
There was NVMEM support added to of_get_mac_address, so it could now
return NULL and ERR_PTR encoded error values, so we need to adjust all
current users of of_get_mac_address to this new fact.

Signed-off-by: Petr Štetiar <redacted>
---
 arch/powerpc/sysdev/tsi108_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c
index 1f1af12..2e54405 100644
--- a/arch/powerpc/sysdev/tsi108_dev.c
+++ b/arch/powerpc/sysdev/tsi108_dev.c
@@ -105,7 +105,7 @@ static int __init tsi108_eth_of_init(void)
 		}
 
 		mac_addr = of_get_mac_address(np);
-		if (mac_addr)
+		if (!IS_ERR_OR_NULL(mac_addr))
 			memcpy(tsi_eth_data.mac_addr, mac_addr, 6);
 
 		ph = of_get_property(np, "mdio-handle", NULL);
-- 
1.9.1

```
